Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[v4.0.0-rc3] Components don't get compiled SCSS inlined #990

Closed
bboehm86 opened this issue Jul 3, 2018 · 3 comments
Closed

[v4.0.0-rc3] Components don't get compiled SCSS inlined #990

bboehm86 opened this issue Jul 3, 2018 · 3 comments

Comments

@bboehm86
Copy link

bboehm86 commented Jul 3, 2018

Type of Issue

[x] Bug Report
[ ] Feature Request

Description

When using a generated lib (build with no errors or warnings and 4.0.0-rc.3) the styles doesn't seem to be inlined when using an external *.scss-file

The styles: [] is missing in the compiled lib @Component() and the browser complains correctly:

:49152/random.component.scss:1 Failed to load resource: the server responded with a status of 404 (Not Found)

How To Reproduce

  • Generate a new Angular CLI project, add a lib, add ng-packagr 4.0.0-rc.3, add a component with external scss-file, compile, inspect the output

or

  1. Clone https://github.com/bboehm86/ng-packagr-scss
  2. yarn
  3. yarn build dummy
  4. Inspect the output in the dist/-dir or use the lib in the app ( yarn start)

Expected Behaviour

The scss-files should be compiled and be included with the components as it is the case in 3.0.3

Version Information

ng-packagr: 4.0.0-rc.3 (+ 4.0.0-rc.2 / 4.0.0-rc.1)
@angular/compiler: 6.0.7
rollup: 0.62.0
tsickle: 0.32.0
typescript: 2.7.2
rxjs: 6.2.1
node: 8.9.0
yarn: 1.7.0
@alan-agius4
Copy link
Member

alan-agius4 commented Jul 3, 2018

From your example it looks like you didn't enable enableResourceInlining in your tsconfig

Please take a look at the breaking changes
https://github.com/dherges/ng-packagr/blob/master/CHANGELOG.md#breaking-changes-1
https://github.com/dherges/ng-packagr/blob/master/CHANGELOG.md#breaking-changes

@bboehm86
Copy link
Author

bboehm86 commented Jul 3, 2018

You are absolutely right! Thanks & sorry I totally missed that :-)

@bboehm86 bboehm86 closed this as completed Jul 3, 2018
@github-actions
Copy link

This issue has been automatically locked due to inactivity. Please file a new issue if you are encountering a similar or related problem.
This action has been performed automatically by a bot.

@github-actions github-actions bot locked and limited conversation to collaborators Jun 19, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Development

No branches or pull requests

2 participants