Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

v5.0.0 Migration Warning #76

Closed
dhershman1 opened this issue Oct 27, 2022 · 8 comments
Closed

v5.0.0 Migration Warning #76

dhershman1 opened this issue Oct 27, 2022 · 8 comments
Labels
breaking ‼️ This issue request is a breaking change

Comments

@dhershman1
Copy link
Owner

dhershman1 commented Oct 27, 2022

Hello! I am writing this issue to hopefully warn everyone using this package that I think I'm going to split it up into 2 packages.

I really really really hate the way the code works between Vue 2 and Vue 3, so I think I'm going to dedicate vue-debounce to Vue3, and then I'll make a new package with which name I shall list here at a later date when this project starts.

Thank you for the support and downloading of this silly little tool!

You can now start migrating to the new package here: vue2-debounce

Edit: It's finally here! #85

@dhershman1 dhershman1 added the breaking ‼️ This issue request is a breaking change label Oct 27, 2022
@dhershman1 dhershman1 pinned this issue Oct 27, 2022
@MartinX3
Copy link

MartinX3 commented Mar 21, 2023

Is this the same for vue 2.7?
It should backport some compatibility from vue 3.

@dhershman1
Copy link
Owner Author

This package is still backward compatible as of right now, I haven't made any clear jump to starting the conversion as I just haven't had the free time.

The idea here is because of the way Vue2 handles plugins or directives like this package is a little bit different than how vue 3 does it. Mostly verbiage and how the install functionality works. Right now vue-debounce has a whole bunch of overhead to try and get you the right version of the directive you need to use for your instance of vue.

I don't like this because it relies on strings, and manually getting the version from the user, kind of stinky. Hence the main reason I want to break up the package

@MartinX3
Copy link

MartinX3 commented Mar 21, 2023

Oh, I thought they also mostly backported in 2.7 how plugins/directives are handled in 3.

@dhershman1
Copy link
Owner Author

I'm not 100% sure, but I'll double-check before I commit to anything, if it is the same then this package would support 2.7 as well, I believe would be the ideal solution (maybe)

@MartinX3
Copy link

That would be nice.
Vue 2.6 is end of life. (2.7 will be on 2023-12-31).

https://v2.vuejs.org/v2/guide/migration-vue-2-7.html

@dhershman1
Copy link
Owner Author

dhershman1 commented Mar 22, 2023

It looks like with my very light digging, that vue 2.7 still uses the same verbiage as the rest of vue2, which does line up. So I don't think vue-debounce would support 2.7 but vue2-debounce (linked above) will continue to support it after v5 of this package releases (You can also choose to just use the current version of vue-debounce for the foreseeable future if needed, but it wouldn't receive patches or chore updates like vue2-debounce would)

luckily vue-debounce is dependency less so it shouldn't have any security risk from third party packages, unless it itself happens to fall into one (which is unlikely)

Hopefully, that makes sense if its gibberish please feel free to ask any more questions and I will do my best to answer or look into them! :D

@MartinX3
Copy link

Oh, sad to hear and thank you for the clarification :D

@dhershman1
Copy link
Owner Author

v5.0.0 has released

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
breaking ‼️ This issue request is a breaking change
Projects
None yet
Development

No branches or pull requests

2 participants