Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ignore non-useful files in hpio.nix #61

Closed
dhess opened this issue Jan 29, 2018 · 2 comments
Closed

Ignore non-useful files in hpio.nix #61

dhess opened this issue Jan 29, 2018 · 2 comments
Assignees
Labels
Milestone

Comments

@dhess
Copy link
Owner

dhess commented Jan 29, 2018

nix-build does not settle on a fixed point; repeated nix-builds with no changes will run each time rather than returning a cached result.

I believe this is because the hpio.nix generated by cabal2nix is using the top-level directory, so things like result files are factoring into the generated hash.

Figure out a way to get around this, perhaps by putting the sdist files in a subdirectory of the top-level directory.

@dhess dhess added the bug label Jan 29, 2018
@dhess dhess added this to the 0.9.0.4 milestone Jan 29, 2018
@dhess dhess self-assigned this Jan 29, 2018
@dhess
Copy link
Owner Author

dhess commented Jan 29, 2018

See:

http://hackage.haskell.org/package/hspec-checkers-0.1.0/src/default.nix
NixOS/cabal2nix#112

Probably want to apply builtins.filterSource in the haskell-overrides.nix overlay, when we callPackage on the various hpio Nix files.

@dhess
Copy link
Owner Author

dhess commented Jan 29, 2018

pkgs.lib.cleanSource and pkgs.lib.cleanSourceWith are what we need here.

@dhess dhess closed this as completed in 70a42a8 Jan 29, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant