Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add styles for tables #41

Closed
RobertAudi opened this issue Sep 15, 2011 · 13 comments
Closed

Add styles for tables #41

RobertAudi opened this issue Sep 15, 2011 · 13 comments

Comments

@RobertAudi
Copy link

I think that as a boilerplate/framework, Skeleton should style tables as well, possibly the same way blueprint does it, with different colors for each rows.

@dstotijn
Copy link

I concur. Table styling would definitely be a nice addition to Skeleton.

@f0x2501
Copy link

f0x2501 commented Sep 28, 2011

It would be nice with a neutral design.

@loqur
Copy link

loqur commented Dec 23, 2011

+1

@dmackerman
Copy link

Wouldn't be too hard to add either. May take a crack at it.

@dstotijn
Copy link

I took a shot at this, borrowing from Bootstrap. Check out my demo and let me know what you think.

@RobertAudi
Copy link
Author

I like what you did, but I'd also like to have the option to have different colors on each row, I think it makes the table data much more readable.

@dstotijn
Copy link

I added zebra striped row styling to the demo. Again cloned from Bootstrap. :)

@f0x2501
Copy link

f0x2501 commented Dec 28, 2011

Congratulations dstotijn, like it, it's rock ;)

@RobertAudi
Copy link
Author

Awesome, thanks a lot ;)

@dstotijn
Copy link

For possible future reference, I've put this here: https://github.com/dstotijn/Skeleton-tables

@dmackerman
Copy link

This should absolutely be merged in.

@RobertAudi
Copy link
Author

I agree

@dhg
Copy link
Owner

dhg commented Jan 26, 2012

Hey fellas -

I appreciate the suggestions and think the tables would certainly be great, but I designed Skeleton to be lightweight and only have the absolute bare bone basics. I rarely use tables and don't want to include more components (if anything, I want to slim it down more). Skeleton was never meant to be robust, but I whole heartedly encourage anyone to use the fork with the tables!

Thanks for your understanding, but hit me up if there is more concern or questions on the issue.

@dhg dhg closed this as completed Jan 26, 2012
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

6 participants