Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Micro-Clearfix? #7

Closed
dhg opened this issue May 18, 2011 · 4 comments
Closed

Micro-Clearfix? #7

dhg opened this issue May 18, 2011 · 4 comments

Comments

@dhg
Copy link
Owner

dhg commented May 18, 2011

Need to test the micro-clearfix across browsers. If it works, it will be a more lightweight solution that I would love to use! (http://nicolasgallagher.com/micro-clearfix-hack/)

Originally suggested by Necolas (https://github.com/necolas)

@Calvein
Copy link
Contributor

Calvein commented May 18, 2011

It works well, it's used on HTML5 Boilerplate too (Necolas is a part of H5BP).

@dhg
Copy link
Owner Author

dhg commented May 18, 2011

Awesome. That sounds like a winner then. I already have it in my local code and just need to quickly test it before I push live. Will probably be out in the next day :)

Cheers!

@dhg
Copy link
Owner Author

dhg commented May 19, 2011

Hey -

Are there are advantages to using this updated clearfix method? I'm looking at my existing one and the "updated" version and it seems like the primary difference is just a display: table instead of block (which means I can remove explicity width: 0; height: 0;).

It's possible I am missing a huge advantage to the switch, but for now the different in length is three lines of CSS...does the render actually change or get any advantage?

Thanks again for your contribution!

Cheers!

@dhg
Copy link
Owner Author

dhg commented May 21, 2011

Continued to play with the micro clearfix and found no real advantage (besides 2 lines of removed CSS). Will continue to use the existing clearfix method unless somebody has an awesome reason to change (in which case I would love to chat about it).

Cheers

@dhg dhg closed this as completed May 21, 2011
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants