-
Notifications
You must be signed in to change notification settings - Fork 3.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
getskeleton site shows 12 columns - confusing #72
Comments
agreed. this threw me too. |
Same. Where can I find 12 grid? |
If you look that is just an example of how it works. View the source of that page and you can see the side bar takes up 3 columns and the actual content of the site takes up 12 columns but it has the class of offset-by-one. this makes up the total of 16 total columns. Skeleton is a 16 column css framework. It is very flexible so if you want a 12 column grid you can modify the css or you can make offset-by-two on each side of your website thus having a 12 column grid. I think this will be very skinny and 16 gives designers/developers for flexibility and power anyways. This issue should probably be closed as it really isn't an issue but more of a css question. |
Hi @edhedges, |
@pferdefleisch Ah ok. I am sorry. I guess my response is a little more relevant to @ibrent and @shovansargunam. I do agree for beginners it could be confusing. A good way around this would be to explain that the grid is 16 columns but here is an example using 12 columns? |
np :)
could be
for example. |
Thanks guys for your help. I am still getting my head around. I have a theme build on Skeleton and I have designed in Foundation Framework (foundation.zurb.com), Trying to hack into Skeleton and make it work for my design. Appreciate your comments. |
The same happened to me. The documentation is a bit confusing in this aspect. |
+1 |
1 similar comment
+1 |
As an example of how Twitter Bootstrap takes care of this same exact issue |
+1 |
This also had me confused. Maybe just updating the documentation would solve this issue? |
+1 |
move to close - new getskeleton site doesn't have error |
This was mad confusing and something that should have been taken care of (or at least explained). New site doesn't suffer from same confusing issue, so that's good! Closing in light of v2.0 |
Hi,
I was just introduced to skeleton through Spree. I really like it.
I was very confused that on the site you give a 12 column example though there are 16 columns in your grid.
The only mention to 16 columns is if you view the source for the example and there is this
which seems super vague to me and almost misleading.
I looked at the source to see that indeed there are 16 columns. I don't know if a less experienced dev would do the same.
I will be using this project often. Thanks for the time you put into it!
aaron
The text was updated successfully, but these errors were encountered: