Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add support for trackedEntities analytics requests (DHIS2-16023) #1594

Merged
merged 21 commits into from
Mar 13, 2024
Merged

feat: add support for trackedEntities analytics requests (DHIS2-16023) #1594

merged 21 commits into from
Mar 13, 2024

Conversation

edoardo
Copy link
Member

@edoardo edoardo commented Nov 17, 2023 •
edited

Implements DHIS2-16023

Relates to dhis2/line-listing-app#451

Key features

  1. implement Analytics class for tracked entities request
  2. add support for the new trackedEntity/query endpoint
  3. adjust dimension id formatting

Description

The PR adds support for the new analytics endpoint for tracked entities.
The outputType selected in LL needs to be taken into account when composing the request URL's path and when formatting the dimension ids.

@martinkrulltott martinkrulltott mentioned this pull request Nov 21, 2023
Merged
35 tasks
@martinkrulltott martinkrulltott changed the title feat: add support for trackedEntities analytics requests feat: add support for trackedEntities analytics requests (DHIS2-16023) Nov 21, 2023
@edoardo edoardo marked this pull request as ready for review January 26, 2024 10:09
HendrikThePendric
HendrikThePendric approved these changes Jan 29, 2024
View reviewed changes
Copy link
Contributor

@HendrikThePendric HendrikThePendric left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code is looking very clear. I don't think I am fully qualified to assess whether or not the changes all make sense, but it certainly looks like a sensible implementation.

I've left 2 comments. Perhaps the one about the version number could be quite vital.

package.json Outdated Show resolved Hide resolved
src/api/analytics/utils.js Outdated Show resolved Hide resolved
@martinkrulltott martinkrulltott merged commit 885af10 into master Mar 13, 2024
2 checks passed
@martinkrulltott martinkrulltott deleted the feat/tracked-entity-input branch March 13, 2024 09:41
dhis2-bot added a commit that referenced this pull request Mar 13, 2024
@dhis2-bot
chore(release): cut 26.6.0 [skip ci]
4ad2823 
# [26.6.0](v26.5.0...v26.6.0) (2024-03-13)

### Features

* add support for trackedEntities analytics requests (DHIS2-16023) ([#1594](#1594)) ([885af10](885af10))
@dhis2-bot
Copy link
Contributor

🎉 This PR is included in version 26.6.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@martinkrulltott martinkrulltott martinkrulltott left review comments

@HendrikThePendric HendrikThePendric HendrikThePendric approved these changes

Assignees

@HendrikThePendric HendrikThePendric

Labels
released
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@edoardo @dhis2-bot @HendrikThePendric @martinkrulltott