fix: interpretations panel renders with flashing when liking or unliking an interpretation #1600
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jenniferarnesen
changed the title
edoardo
approved these changes
Feb 5, 2024
edoardo
force-pushed
the
fix/like-causing-flashing-interp-panel
branch
from
410376b
to
fe2a3d3
Compare
|
🎉 This PR is included in version 26.4.1 🎉 The release is available on: Your semantic-release bot 📦🚀 |
jenniferarnesen
added a commit
that referenced
this pull request
Mar 22, 2024
…ing an interpretation (#1600) * fix: rendering a spinner based on fetching causes flash * fix: dont use loader and mask when like/unliking * fix: when liking just update the object instead of new request * fix: unneeded changes * fix: unneeded changes * fix: more cleanup * fix: set dirty so parent component refreshes interpretations list --------- Co-authored-by: Edoardo Sabadelli <edoardo@dhis2.org>
jenniferarnesen
added a commit
that referenced
this pull request
Apr 2, 2024
…ing an interpretation (#1643) Fixes: https://dhis2.atlassian.net/browse/DHIS2-16392 Backport of #1600 --------- Co-authored-by: Edoardo Sabadelli <edoardo@dhis2.org>
This was referenced Apr 3, 2024
fix: upgrade analytics for interpretations like/unlike flashing [v39]
dhis2/data-visualizer-app#3012
Merged
jenniferarnesen
added a commit
to dhis2/data-visualizer-app
that referenced
this pull request
Apr 3, 2024
…#3012) Fixes: https://dhis2.atlassian.net/browse/DHIS2-16392 Related analytics PR: dhis2/analytics#1643 PR showing the fix: dhis2/analytics#1600
jenniferarnesen
added a commit
to dhis2/maps-app
that referenced
this pull request
Apr 3, 2024
Fixes: https://dhis2.atlassian.net/browse/DHIS2-16392 Related analytics PR: dhis2/analytics#1643 PR showing the fix: PR showing the fix: dhis2/analytics#1600
dhis2-bot
added a commit
to dhis2/data-visualizer-app
that referenced
this pull request
Apr 3, 2024
## [39.2.23](v39.2.22...v39.2.23) (2024-04-03) ### Bug Fixes * upgrade analytics for interpretations like/unlike flashing [v39] ([#3012](#3012)) ([58ca653](58ca653)), closes [dhis2/analytics#1643](dhis2/analytics#1643) [dhis2/analytics#1600](dhis2/analytics#1600)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: https://dhis2.atlassian.net/browse/DHIS2-16392
Fixes flashing when liking/unliking an interpretation.
Seems unnecessary to render a loader when fetching. There is already a loader for loading state, which happens on initial load.
Adding the spinner to the DOM was causing big flashing:
Before:
https://github.com/dhis2/analytics/assets/6113918/482f3d0d-cb71-4751-b072-5a367199c364
After:
like-doesnt-cause-flash.mov