fix: height in safari (DHIS2-8277) #303
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dhis2-bot
added a commit
that referenced
this pull request
Feb 21, 2020
## [3.2.5](v3.2.4...v3.2.5) (2020-02-21) ### Bug Fixes * height in safari (DHIS2-8277) ([#303](#303)) ([0a53aea](0a53aea))
|
🎉 This PR is included in version 3.2.5 🎉 The release is available on:
Your semantic-release bot 📦🚀 |
martinkrulltott
added a commit
to dhis2/data-visualizer-app
that referenced
this pull request
Feb 21, 2020
* fix: main-center-canvas explicit height to support safari * chore: updated @dhis2/cli-app-scripts to 3.2.5 Fixes the height issue in Safari for DV (https://jira.dhis2.org/browse/DHIS2-8277) by updating the app-platform dep (fixes the container height) and setting an explicit height for the main-center-canvas (fixes the height of the main content). Deps on dhis2/app-platform#303
dhis2-bot
added a commit
to dhis2/data-visualizer-app
that referenced
this pull request
Feb 21, 2020
## [34.2.6](v34.2.5...v34.2.6) (2020-02-21) ### Bug Fixes * height in safari (DHIS2-8277) ([#704](#704)) ([75994b3](75994b3)), closes [dhis2/app-platform#303](dhis2/app-platform#303)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes the height issue in Safari for DV (https://jira.dhis2.org/browse/DHIS2-8277) by explicitly setting the height of the app to
100%.Correct height:
