Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: rename 'update' test command handler parameter to 'updateSnapshot' #577

Merged
merged 1 commit into from
Jun 30, 2021

Conversation

mediremi
Copy link
Contributor

The updateSnapshot parameter for the test command was incorrectly referred to as update in its handler, hence it was impossible to set it to true.

@mediremi mediremi enabled auto-merge (squash) June 30, 2021 12:42
Copy link
Member

@amcgee amcgee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice catch, lgtm! Not sure why publish step is failing... @varl

@mediremi mediremi merged commit 34787ad into master Jun 30, 2021
@mediremi mediremi deleted the fix/jest-update-snapshot branch June 30, 2021 13:15
@amcgee
Copy link
Member

amcgee commented Jun 30, 2021

Shoot... might be a problem with the publish command here? Maybe it's a problem with cli-utils release?

dhis2-bot added a commit that referenced this pull request Jun 30, 2021
## [7.0.1](v7.0.0...v7.0.1) (2021-06-30)

### Bug Fixes

* rename 'update' test command handler parameter to 'updateSnapshot' ([#577](#577)) ([34787ad](34787ad))
@dhis2-bot
Copy link
Contributor

🎉 This PR is included in version 7.0.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

dhis2-bot added a commit that referenced this pull request Jun 30, 2021
# [7.1.0-beta.2](v7.1.0-beta.1...v7.1.0-beta.2) (2021-06-30)

### Bug Fixes

* rename 'update' test command handler parameter to 'updateSnapshot' ([#577](#577)) ([34787ad](34787ad))
@dhis2-bot
Copy link
Contributor

🎉 This PR is included in version 7.1.0-beta.2 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

None yet

3 participants