fix(service-worker): change routing to allow redirect to login page #669
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mediremi
reviewed
Oct 4, 2021
| // a file extension, skip (unless it's index.html) | ||
| if ( | ||
| fileExtensionRegexp.test(url.pathname) && | ||
| !/index\.html$/.test(url.pathname) |
There was a problem hiding this comment.
The (relatively) new String.prototype.endsWith would allow making the intention of this line a bit clearer:
Suggested change
| !/index\.html$/.test(url.pathname) | |
| !url.pathname.endsWith("index.html") |
mediremi
reviewed
Oct 4, 2021
| // Extract index.html from the manifest to precache, then route | ||
| // in a custom way | ||
| const indexHtmlManifestEntry = precacheManifest.find(({ url }) => | ||
| url.includes('index.html') |
There was a problem hiding this comment.
Maybe this should be url.endsWith('index.html') too since this would match e.g. index.html.js
There was a problem hiding this comment.
Hah yeah, fair point 🙂
mediremi
approved these changes
Oct 4, 2021
dhis2-bot
added a commit
that referenced
this pull request
Oct 4, 2021
## [8.1.2](v8.1.1...v8.1.2) (2021-10-04) ### Bug Fixes * **service-worker:** change routing to allow redirect to login page ([#669](#669)) ([97c84d4](97c84d4))
|
🎉 This PR is included in version 8.1.2 🎉 The release is available on:
Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses https://jira.dhis2.org/browse/LIBS-238
Can be tested like this:
pwapackage,adapterpackage, then the pwa-app/api/apps/pwa-app/and/api/apps/pwa-app/index.html; verify app loads/api/apps/pwa-app/hiand verify app loads (tests that subroutes are handled by index.html)/api/apps/pwa-app//manifest.jsonto make sure you can visit static files