Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(deps): resolution for app-runtime alpha #839

Merged
merged 2 commits into from
Apr 5, 2024

Conversation

KaiVandivier
Copy link
Contributor

@KaiVandivier KaiVandivier commented Apr 5, 2024

The dependency loop for @dhis2/app-service-data is fixed by the change in the alpha branch of @dhis2/app-runtime, but @dhis2/ui depends on main release of @dhis2/app-runtime as well, which then ends up running into same the app-runtime loop -- hopefully this resolution works for NPM to fix the loop from the UI dependency on app runtime

Result: this did not make a difference

@KaiVandivier KaiVandivier merged commit c4a90d9 into alpha Apr 5, 2024
6 checks passed
@KaiVandivier KaiVandivier deleted the libs-587-resolution-for-app-runtime branch April 5, 2024 17:28
dhis2-bot added a commit that referenced this pull request Apr 5, 2024
## [11.1.1-alpha.2](v11.1.1-alpha.1...v11.1.1-alpha.2) (2024-04-05)

### Bug Fixes

* **deps:** resolution for app-runtime alpha ([#839](#839)) ([c4a90d9](c4a90d9))
@dhis2-bot
Copy link
Contributor

🎉 This PR is included in version 11.1.1-alpha.2 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

None yet

2 participants