Pull Request Guidelines

PR title

The title of the pull request needs to follow the commitlint pattern. You also need to add the Jira issue number [DHIS2-XXXXX]. An example of such a title would be

• fix: [DHIS2-8519] field validation bug ….

By doing so we will have a clear history on the master branch.

Merge agreements

Developers review

You need at least one approval from the developers.

QA review

You need at least one approval from the QA. See more details on the Testing and QA workflow

Resolve conversation

The reviewer is in charge to click the "Resolve conversation" button once a solution was agreed upon and/or implemented.

CI Checks

The Cypress end-to-end tests run against a real backend instance. If the API has bugs then Cypress tests may fail.

All Cypress tests need to pass for the app to be published.

Cypress tests to follow up on (the tests are commented out from our code base)

Jira ticket	Known fail	Version	Cause (backend, frontend, test)
DHIS2-13960	User interacts with tei working lists -> Show only teis with active enrollments and unassinged events using the filter	39	Backend
DHIS2-14837	User creates a new entries from the registration page -> New person in Tracker Program > Submitting the form with empty visit date throws validation error	38-40	Frontend
DHIS2-10215	User adds events -> User adds event with relationship to new person in the malaria case registration program	40	Backend
DHIS2-10215	User interacts with Search page -> Searching using attributes in Tracker Program returns no results	40	Backend
DHIS2-10215	User searches for existing TEInstance in the context of adding a relationship -> Searching using attributes in Tracker Program domain has disabled pagination	40	Backend
DHIS2-10215	User searches for existing TEInstance in the context of adding a relationship -> Searching using attributes in TEType domain has disabled pagination	40	Backend
	User can navigate back and forward between the enrollment event edit page and the enrollment page	40	Frontend
	User can save a Sputum smear microscopy test without completing	40	Frontend
	User can complete a Lab monitoring Event	40	Frontend
DHIS2-15814	User can view the list of events	41	Frontend
DHIS2-15814	User can sort the list of events	41	Frontend
DHIS2-15814	User can see the enrollment details	41	Frontend
DHIS2-16010	Main page > Url with invalid program id	41	Frontend
TECH-1662	User with search scope access tries to access an enrollment in a protected program	41	Frontend
DHIS2-16596	Go to enrollment event when Open data entry form after enrollment is checked	41	Backend