Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: show tag/tooltip about not applied filters for Outlier table (DHIS2-13858) #2937

Merged
merged 27 commits into from
Mar 19, 2024
Merged

fix: show tag/tooltip about not applied filters for Outlier table (DHIS2-13858) #2937

merged 27 commits into from
Mar 19, 2024

Conversation

edoardo
Copy link
Member

@edoardo edoardo commented Mar 19, 2024 •
edited by jira bot

Part of DHIS2-13858

Key features

  1. Show "Some filters not applied" tag for Outlier table dashboard items
  2. Implement tooltip explaining about the not applied filters

Description

Dashboard filters other than Period and Organisation unit do no apply to Outlier table visualizations.
This PR implements a tag and tooltip similarly to what is used for LL dashboard items.
The tooltip explains which filters are applied for Outlier table dashboard items.

Screenshots

Screenshot 2024-03-19 at 13 38 56

dhis2-bot and others added 24 commits December 12, 2023 09:36
@dhis2-bot @jenniferarnesen
fix(translations): sync translations from transifex (dev)
0b0c7cf 
Automatically merged.
@janhenrikoverland
chore: analytics (#2856)
6a22f08 
* chore: 26.2.0-cumulative-values-alpha.1

* chore: analytics@26.2.0
@dependabot
chore(deps): bump @adobe/css-tools from 4.3.1 to 4.3.2
9d83c09 
Bumps [@adobe/css-tools](https://github.com/adobe/css-tools) from 4.3.1 to 4.3.2.
- [Changelog](https://github.com/adobe/css-tools/blob/main/History.md)
- [Commits](https://github.com/adobe/css-tools/commits)

---
updated-dependencies:
- dependency-name: "@adobe/css-tools"
  dependency-type: indirect
...

Signed-off-by: dependabot[bot] <support@github.com>
@dhis2-bot
fix(translations): sync translations from transifex (dev)
db5128a 
Automatically merged.
@jenniferarnesen
Merge branch 'dev' into dependabot/npm_and_yarn/adobe/css-tools-4.3.2
678edc2
@jenniferarnesen
Merge pull request #2836 from dhis2/dependabot/npm_and_yarn/adobe/css…
fbcf30c 
…-tools-4.3.2

chore(deps): bump @adobe/css-tools from 4.3.1 to 4.3.2
@dependabot @jenniferarnesen
chore(deps): bump browserify-sign from 4.2.1 to 4.2.2 (#2807)
4d43b23 
Bumps [browserify-sign](https://github.com/crypto-browserify/browserify-sign) from 4.2.1 to 4.2.2.
- [Changelog](https://github.com/browserify/browserify-sign/blob/main/CHANGELOG.md)
- [Commits](browserify/browserify-sign@v4.2.1...v4.2.2)

---
updated-dependencies:
- dependency-name: browserify-sign
  dependency-type: indirect
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Jen Jones Arnesen <jennifer@dhis2.org>
@dependabot @jenniferarnesen
chore(deps): bump crypto-js from 4.1.1 to 4.2.0 (#2806)
3518e64 
Bumps [crypto-js](https://github.com/brix/crypto-js) from 4.1.1 to 4.2.0.
- [Commits](brix/crypto-js@4.1.1...4.2.0)

---
updated-dependencies:
- dependency-name: crypto-js
  dependency-type: indirect
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Jen Jones Arnesen <jennifer@dhis2.org>
@dependabot @jenniferarnesen
chore(deps): bump get-func-name from 2.0.0 to 2.0.2 (#2748)
166186b 
Bumps [get-func-name](https://github.com/chaijs/get-func-name) from 2.0.0 to 2.0.2.
- [Release notes](https://github.com/chaijs/get-func-name/releases)
- [Commits](https://github.com/chaijs/get-func-name/commits/v2.0.2)

---
updated-dependencies:
- dependency-name: get-func-name
  dependency-type: indirect
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Jen Jones Arnesen <jennifer@dhis2.org>
@jenniferarnesen
chore: use the repo default branch for dependabot (#2887)
34bf16e
@jenniferarnesen @janhenrikoverland
chore: include patch packages in cache-key (#2855)
252a0cf 
Related to https://dhis2.atlassian.net/browse/LIBS-383

Add package patches to the yarn cache key.

If a new patch is added, then this ensures that that the yarn cache
gets invalidated and forces yarn install, which will then do the
postinstall step that applies the patches.

From user perspective, the e2e-prod tests might fail if it is depending
on a patch that didn't get installed.

Co-authored-by: Jan Henrik Øverland <janhenrik.overland@gmail.com>
@dependabot @jenniferarnesen
chore(deps): bump react-redux from 7.2.4 to 7.2.9 (#2893)
b99c5ac 
Bumps [react-redux](https://github.com/reduxjs/react-redux) from 7.2.4 to 7.2.9.
- [Release notes](https://github.com/reduxjs/react-redux/releases)
- [Changelog](https://github.com/reduxjs/react-redux/blob/master/CHANGELOG.md)
- [Commits](reduxjs/react-redux@v7.2.4...v7.2.9)

---
updated-dependencies:
- dependency-name: react-redux
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Jen Jones Arnesen <jennifer@dhis2.org>
@dependabot @jenniferarnesen
chore(deps): bump moment from 2.29.4 to 2.30.1 (#2892)
56fcaa4 
Bumps [moment](https://github.com/moment/moment) from 2.29.4 to 2.30.1.
- [Changelog](https://github.com/moment/moment/blob/develop/CHANGELOG.md)
- [Commits](moment/moment@2.29.4...2.30.1)

---
updated-dependencies:
- dependency-name: moment
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Jen Jones Arnesen <jennifer@dhis2.org>
@dependabot
chore(deps): bump @dhis2/d2-i18n from 1.1.1 to 1.1.3 (#2896)
06e0eb3 
Bumps [@dhis2/d2-i18n](https://github.com/dhis2/d2-i18n) from 1.1.1 to 1.1.3.
- [Release notes](https://github.com/dhis2/d2-i18n/releases)
- [Changelog](https://github.com/dhis2/d2-i18n/blob/master/CHANGELOG.md)
- [Commits](dhis2/d2-i18n@v1.1.1...v1.1.3)

---
updated-dependencies:
- dependency-name: "@dhis2/d2-i18n"
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
@dependabot @jenniferarnesen
chore(deps): bump @babel/traverse from 7.18.13 to 7.23.2 (#2796)
201d673 
Bumps
[@babel/traverse](https://github.com/babel/babel/tree/HEAD/packages/babel-traverse)
 from 7.18.13 to 7.23.2.
- [Release notes](https://github.com/babel/babel/releases)
- [Changelog](https://github.com/babel/babel/blob/main/CHANGELOG.md)
- [Commits](https://github.com/babel/babel/commits/v7.23.2/packages/babel-traverse)

---
updated-dependencies:
- dependency-name: "@babel/traverse"
  dependency-type: indirect
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Jen Jones Arnesen <jennifer@dhis2.org>
@dependabot @jenniferarnesen
chore(deps): bump @dhis2/app-runtime from 3.9.4 to 3.10.2 (#2890)
7a12d98 
* chore(deps): bump @dhis2/app-runtime from 3.9.4 to 3.10.2

Bumps
[@dhis2/app-runtime](https://github.com/dhis2/app-runtime/tree/HEAD/runtime)
from 3.9.4 to 3.10.2.
- [Release notes](https://github.com/dhis2/app-runtime/releases)
- [Changelog](https://github.com/dhis2/app-runtime/blob/master/CHANGELOG.md)
- [Commits](https://github.com/dhis2/app-runtime/commits/v3.10.2/runtime)

---
updated-dependencies:
- dependency-name: "@dhis2/app-runtime"
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>

* chore(deps): bump @dhis2/d2-i18n from 1.1.1 to 1.1.3 (#2896)

Bumps [@dhis2/d2-i18n](https://github.com/dhis2/d2-i18n) from 1.1.1 to 1.1.3.
- [Release notes](https://github.com/dhis2/d2-i18n/releases)
- [Changelog](https://github.com/dhis2/d2-i18n/blob/master/CHANGELOG.md)
- [Commits](dhis2/d2-i18n@v1.1.1...v1.1.3)

---
updated-dependencies:
- dependency-name: "@dhis2/d2-i18n"
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* chore(deps): bump @babel/traverse from 7.18.13 to 7.23.2 (#2796)

Bumps
[@babel/traverse](https://github.com/babel/babel/tree/HEAD/packages/babel-traverse)
 from 7.18.13 to 7.23.2.
- [Release notes](https://github.com/babel/babel/releases)
- [Changelog](https://github.com/babel/babel/blob/main/CHANGELOG.md)
- [Commits](https://github.com/babel/babel/commits/v7.23.2/packages/babel-traverse)

---
updated-dependencies:
- dependency-name: "@babel/traverse"
  dependency-type: indirect
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Jen Jones Arnesen <jennifer@dhis2.org>

---------

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Jen Jones Arnesen <jennifer@dhis2.org>
@jenniferarnesen
chore: include release notes in slackbot message (#2911)
c2798d0
@dhis2-bot
fix(translations): sync translations from transifex (dev) (#2920)
c3110d8
@jenniferarnesen
fix: use interpretations component from Analytics (DHIS2-15441) (#2430)
3550cfa
@edoardo
feat: support outlier table plugin (DHIS2-16751) (#2912)
0ee6322
@jenniferarnesen
chore: run the release step on both master and dev branches (#2929)
ee1fc94 
For the 41 soft freeze period, the app bundle needs to be deployed to d2-ci.
Since it will be built from the 'dev' branch, we need to run the deploy build step on 'dev'
@dhis2-bot
fix(translations): sync translations from transifex (dev)
44cd380 
Automatically merged.
@edoardo
chore: update analytics dependency (#2934)
602c670 
* chore: use latest alpha for testing

* chore: update analytics dependency

* test: use 41 test instance
@edoardo
fix: show tag and tooltip about not applied filters (DHIS2-13858)
1734549
@dhis2-bot
Copy link
Contributor

dhis2-bot commented Mar 19, 2024 •
edited

🚀 Deployed on https://pr-2937--dhis2-dashboard.netlify.app

@dhis2-bot dhis2-bot temporarily deployed to netlify March 19, 2024 12:46 Inactive
@edoardo @jenniferarnesen
chore: update analytics dependency (#2934)
b919316 
* chore: use latest alpha for testing

* chore: update analytics dependency

* test: use 41 test instance
@cypress Cypress
Copy link

cypress bot commented Mar 19, 2024

Passing run #4620 ↗︎

0 52 0 0 Flakiness 0

Details:

chore: update analytics dependency (#2934)
Project: dashboards-app Commit: b919316b33
Status: Passed Duration: 03:17 💡
Started: Mar 19, 2024 2:13 PM Ended: Mar 19, 2024 2:16 PM

Review all test suite changes for PR #2937 ↗︎

@dhis2-bot dhis2-bot temporarily deployed to netlify March 19, 2024 14:23 Inactive
@edoardo edoardo merged commit dffb754 into dev Mar 19, 2024
14 checks passed
@edoardo edoardo deleted the fix/filter-with-outlier-table branch March 19, 2024 15:13
dhis2-bot added a commit that referenced this pull request Mar 21, 2024
@dhis2-bot
chore(release): cut 100.1.0 [skip release]
157fdda 
# [100.1.0](v100.0.4...v100.1.0) (2024-03-21)

### Bug Fixes

* show tag/tooltip about not applied filters for Outlier table (DHIS2-13858) ([#2937](#2937)) ([dffb754](dffb754))
* show tag/tooltip only when a filter other than ou/pe is used ([#2941](#2941)) ([b6b8850](b6b8850))
* **translations:** sync translations from transifex (dev) ([755c6df](755c6df))
* use interpretations component from Analytics (DHIS2-15441) ([#2430](#2430)) ([0af5c5b](0af5c5b))
* **translations:** sync translations from transifex (dev) ([0de3606](0de3606))
* **translations:** sync translations from transifex (dev) ([b88e87c](b88e87c))
* **translations:** sync translations from transifex (dev) ([#2920](#2920)) ([add7139](add7139))

### Features

* support outlier table plugin (DHIS2-16751) ([#2912](#2912)) ([1af22d5](1af22d5))
@dhis2-bot
Copy link
Contributor

🎉 This PR is included in version 100.1.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jenniferarnesen jenniferarnesen Awaiting requested review from jenniferarnesen

Assignees
No one assigned
Labels
released
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@edoardo @dhis2-bot @jenniferarnesen @janhenrikoverland