DHIS2-4749: fix comparison for finding app widget #209
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It seems that by coincidence folderName was matching appKey. But folderName has changed now, and in any case it was wrong to compare folderName with appKey as key is what is actually read and written in dashboardItems.
jenniferarnesen
approved these changes
Sep 21, 2018
edoardo
added a commit
that referenced
this pull request
Sep 21, 2018
It seems that by coincidence folderName was matching appKey. But folderName has changed now, and in any case it was wrong to compare folderName with appKey as key is what is actually read and written in dashboardItems and comes from the same object present in both api/apps and api/dashboard/q responses. (cherry picked from commit 7ed4ea3)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It seems that by coincidence folderName was matching appKey. But
folderName has changed now, and in any case it was wrong to compare
folderName with appKey as key is what is actually read and written in
dashboardItems and comes from the same object present in both api/apps and api/dashboard/q responses.