Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: non-existing AO blocks new AOs from being created (DHIS2-13167) #3056

Merged
merged 2 commits into from
May 30, 2024

Conversation

martinkrulltott
Copy link
Contributor

@martinkrulltott martinkrulltott commented May 15, 2024

Implements DHIS2-13167


Key features

  1. Clear ao id when 404 is returned

TODO

  • Manual testing

Screenshots

before and after

old.vs.new.mov

@dhis2-bot
Copy link
Contributor

dhis2-bot commented May 15, 2024

@dhis2-bot dhis2-bot temporarily deployed to netlify May 15, 2024 08:32 Inactive
Copy link

cypress bot commented May 15, 2024

Passing run #2845 ↗︎

0 741 2 0 Flakiness 0

Details:

Merge 1a92edd into 682b4a0...
Project: Data Visualizer App Commit: 860f6ad299 ℹ️
Status: Passed Duration: 18:35 💡
Started: May 21, 2024 1:29 PM Ended: May 21, 2024 1:48 PM

Review all test suite changes for PR #3056 ↗︎

@martinkrulltott martinkrulltott enabled auto-merge (squash) May 30, 2024 13:42
@martinkrulltott martinkrulltott merged commit b9b5beb into dev May 30, 2024
38 of 39 checks passed
@martinkrulltott martinkrulltott deleted the fix/DHIS2-13167-invalid-ao-id branch May 30, 2024 14:10
dhis2-bot added a commit that referenced this pull request Jun 6, 2024
## [100.5.5](v100.5.4...v100.5.5) (2024-06-06)

### Bug Fixes

* dimension chip design updates (DHIS2-16272) ([#2934](#2934)) ([9b23fbd](9b23fbd))
* non-existing AO blocks new AOs from being created (DHIS2-13167) ([#3056](#3056)) ([2bf0d53](2bf0d53))
* numbers are misaligned in pivot table (DHIS2-16900) ([#3072](#3072)) ([3ee3a83](3ee3a83))
* **translations:** sync translations from transifex (dev) ([8dd390b](8dd390b))
* system / user setting for display name not respected in Org Unit tree (DHIS2-15000) ([#3051](#3051)) ([4a79d5b](4a79d5b))
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants