feat: add support for hash routing which is used by other analytics apps [DHIS2-15762] #3009
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…lem with jest tests
|
🚀 Deployed on https://pr-3009--dhis2-maps.netlify.app |
jenniferarnesen
changed the base branch from
dev
to
chore/useQueryCacheProvider
1 flaky test on run #2859 ↗︎
Details:
|
|||||||||||||||||||||
| Test | Artifacts | |
|---|---|---|
| Data Download > downloads data from an event layer |
Screenshots
|
|
Review all test suite changes for PR #3009 ↗︎
There was a problem hiding this comment.
I've left some comments/questions....
Looking at the code changes it feels more likely that the re-rendering issues you encountered are related to history state changes rather than the useAlert hook. But you have obviously found that creating this custom hook fixed the issue, so I guess there is either some interaction between these two things, or there is something at play that I don't fully understand.
… location and action
…eat/router-latest
dhis2-bot
added a commit
that referenced
this pull request
Jan 12, 2024
# [100.3.0](v100.2.3...v100.3.0) (2024-01-12) ### Features * add support for hash routing in line with other analytics apps [DHIS2-15762] ([#3009](#3009)) ([b25267d](b25267d))
|
🎉 This PR is included in version 100.3.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
jenniferarnesen
pushed a commit
that referenced
this pull request
Jan 23, 2024
# [100.3.0](v100.2.3...v100.3.0) (2024-01-12) ### Features * add support for hash routing in line with other analytics apps [DHIS2-15762] ([#3009](#3009)) ([b25267d](b25267d))
jenniferarnesen
added a commit
that referenced
this pull request
Jan 24, 2024
* chore(release): cut 100.3.0 [skip release] # [100.3.0](v100.2.3...v100.3.0) (2024-01-12) ### Features * add support for hash routing in line with other analytics apps [DHIS2-15762] ([#3009](#3009)) ([b25267d](b25267d)) * chore(deps): bump @dhis2/app-runtime from 3.9.4 to 3.10.2 Bumps [@dhis2/app-runtime](https://github.com/dhis2/app-runtime/tree/HEAD/runtime) from 3.9.4 to 3.10.2. - [Release notes](https://github.com/dhis2/app-runtime/releases) - [Changelog](https://github.com/dhis2/app-runtime/blob/master/CHANGELOG.md) - [Commits](https://github.com/dhis2/app-runtime/commits/v3.10.2/runtime) --- updated-dependencies: - dependency-name: "@dhis2/app-runtime" dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com> --------- Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: @dhis2-bot <apps@dhis2.org> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Jen Jones Arnesen <jennifer@dhis2.org>
HendrikThePendric
pushed a commit
that referenced
this pull request
Jan 25, 2024
* chore(release): cut 100.3.0 [skip release] # [100.3.0](v100.2.3...v100.3.0) (2024-01-12) ### Features * add support for hash routing in line with other analytics apps [DHIS2-15762] ([#3009](#3009)) ([b25267d](b25267d)) * chore(deps): bump @dhis2/app-runtime from 3.9.4 to 3.10.2 Bumps [@dhis2/app-runtime](https://github.com/dhis2/app-runtime/tree/HEAD/runtime) from 3.9.4 to 3.10.2. - [Release notes](https://github.com/dhis2/app-runtime/releases) - [Changelog](https://github.com/dhis2/app-runtime/blob/master/CHANGELOG.md) - [Commits](https://github.com/dhis2/app-runtime/commits/v3.10.2/runtime) --- updated-dependencies: - dependency-name: "@dhis2/app-runtime" dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com> --------- Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: @dhis2-bot <apps@dhis2.org> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Jen Jones Arnesen <jennifer@dhis2.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implements https://dhis2.atlassian.net/browse/DHIS2-15762
Continue to support the old url patterns for backwards compatibility
Supports:
The app supports legacy urls (see above) because dashboard-app still produces the legacy url for both opening the map, and opening an interpretation. In addition, urls to maps may have been shared in other ways. In maps-app, legacy urls are replaced with the new url style when the maps-app first opens (AppWrapper)
FileMenu: push paths to history for the various actions. Also, some renaming was done in the file to (hopefully) increase clarity.useLoadMap: this is where all the map loading and history listening is set up. history.listen implementation has been copied from LL and adjusted as needed to support maps.Refactoring. Previously there were 3 components that dealt with initiating the maps app: AppWrapper, App, AppLayout.
Apphas become the former "AppLayout", and all of the loading and navigating logic has been moved to the new custom hookuseLoadMap