feat: disable download button until map is rendered #3072
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
🚀 Deployed on https://pr-3072--dhis2-maps.netlify.app |
2 flaky tests on run #3028 ↗︎
Details:
|
|||||||||||||||||||||||||||
| Test | Artifacts | |
|---|---|---|
| Routes > navigation by url changes > navigates from currentAnalyticalObject to saved map in download mode |
Screenshots
|
|
basemaps.cy.js • 1 flaky test • e2e-chrome-parallel-2.40
| Test | Artifacts | |
|---|---|---|
| Basemap checks > open map with no basemap uses fallback basemap (OSM Light) when system default basemap is not set |
Screenshots
|
|
Review all test suite changes for PR #3072 ↗︎
HendrikThePendric
approved these changes
Dec 5, 2023
| <Button primary onClick={onDownload}> | ||
| <Button | ||
| primary | ||
| disabled={!isRendered} |
There was a problem hiding this comment.
Great! In puppeteer I can wait until the button is enabled and then take a screenshot.
|
Added an |
HendrikThePendric
force-pushed
the
feat/map-rendered
branch
from
6894755
to
52b4c11
Compare
jenniferarnesen
approved these changes
Mar 4, 2024
jenniferarnesen
added a commit
that referenced
this pull request
Mar 18, 2024
…l map is rendered (#3072) * feat: disable download button until map is rendered * chore: code cleaning * chore: code cleaning * chore: code comment * fix: isPushAnalytics url param * fix: isPushAnalytics url param * chore: update @dhis2/analytics and deduplicate deps * chore: read single url param * fix: ensure isDownload is a bool to avoid prop-types error * fix: add class-names for push-analytics * fix: check download param when navigating to new * fix: prevent enabling download button while loading mask is showing * fix: add class to map container when no map id is set * fix: improve hover states and add consistent spacing [UX-161] (#3121) * fix: make `dhis2-map-new` class independent of downloadMode * feat: add push analytics instructions * chore: upgrade @dhis2/maps-gl --------- Co-authored-by: HendrikThePendric <hendrik@dhis2.org> Co-authored-by: Jen Jones Arnesen <jennifer@dhis2.org> Co-authored-by: Joseph John Aas Cooper <joe@dhis2.org>
dhis2-bot
added a commit
that referenced
this pull request
Mar 18, 2024
# [100.5.0](v100.4.1...v100.5.0) (2024-03-18) ### Bug Fixes * navigating by the changing url ignored download mode and interpretation id parameters ([#3125](#3125)) ([fcc5eaa](fcc5eaa)) * **translations:** sync translations from transifex (dev) ([#3132](#3132)) ([7f5d178](7f5d178)) * improve hover states and add consistent spacing [UX-161] ([#3121](#3121)) ([3f9e667](3f9e667)) ### Features * add ability to add GeoJSON URL external layers ([#3127](#3127)) ([fbdf0b0](fbdf0b0)), closes [#3142](#3142) [#3144](#3144) [#3145](#3145) [#3149](#3149) [#3148](#3148) [#3147](#3147) [#3143](#3143) [#3151](#3151) [#3154](#3154) * when rendering for push analytics, disable download button until map is rendered ([#3072](#3072)) ([4b1076c](4b1076c)), closes [#3121](#3121)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implements https://dhis2.atlassian.net/browse/DHIS2-16357
This PR will make sure the download map button is disabled if the map is still being rendered.
Related PR: dhis2/maps-gl#552
For push analytics, the map can be rendered when there is no
disabledattribute on theDownloadbutton.The scope of this PR was extended slightly by @HendrikThePendric. It now also contains changes that ensure certain class names are in place and the app is served with a JSON instructions file.