Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: analytics upgrade fixes paragraph newlines in description #3182

Merged
merged 1 commit into from
Apr 24, 2024
Merged

fix: analytics upgrade fixes paragraph newlines in description #3182

merged 1 commit into from
Apr 24, 2024
+5 −5

Conversation

jenniferarnesen
Copy link
Collaborator

@jenniferarnesen jenniferarnesen commented Apr 22, 2024 •
edited
Loading

Before:
image

After:
image

@dhis2-bot
Copy link
Contributor

🚀 Deployed on https://pr-3182--dhis2-maps.netlify.app

@dhis2-bot dhis2-bot temporarily deployed to netlify April 22, 2024 11:56 Inactive
@cypress Cypress
Copy link

cypress bot commented Apr 22, 2024 •
edited
Loading

3 flaky tests on run #3157 ↗︎

0 59 16 0 Flakiness 3

Details:

Merge 955a17b into 0348ce6...
Project: maps Commit: 0da8b401ab ℹ️
Status: Passed Duration: 03:40 💡
Started: Apr 23, 2024 9:37 AM Ended: Apr 23, 2024 9:40 AM
Flakiness  routes.cy.js • 1 flaky test • e2e-chrome-parallel-2.41

View Output

Test Artifacts
Routes > loads download page currentAnalyticalObject (hash) Screenshots
Flakiness  interpretations.cy.js • 1 flaky test • e2e-chrome-parallel-2.41

View Output

Test Artifacts
Interpretations > view interpretation after creating a map Screenshots
Flakiness  filemenu.cy.js • 1 flaky test • e2e-chrome-parallel-2.41

View Output

Test Artifacts
File menu > saves a new map Screenshots

Review all test suite changes for PR #3182 ↗︎

@jenniferarnesen jenniferarnesen merged commit 1e40100 into dev Apr 24, 2024
36 checks passed
@jenniferarnesen jenniferarnesen deleted the chore/upgrade-analytics-for-interpretation-flashing branch April 24, 2024 12:02
@jenniferarnesen jenniferarnesen mentioned this pull request Apr 24, 2024
Merged
dhis2-bot added a commit that referenced this pull request Apr 24, 2024
@dhis2-bot
chore(release): cut 100.5.2 [skip release]
738180a 
## [100.5.2](v100.5.1...v100.5.2) (2024-04-24)

### Bug Fixes

* paragraph newlines in map description were being removed ([#3182](#3182)) ([1e40100](1e40100))
* **translations:** sync translations from transifex (dev) ([63bce3d](63bce3d))
@dhis2-bot
Copy link
Contributor

🎉 This PR is included in version 100.5.2 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@HendrikThePendric HendrikThePendric HendrikThePendric approved these changes

Assignees
No one assigned
Labels
released
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@jenniferarnesen @dhis2-bot @HendrikThePendric