fix: system / user setting for display name not respected in Org Unit tree (DHIS2-15000) #3195
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
🚀 Deployed on https://pr-3195--dhis2-maps.netlify.app |
jenniferarnesen
changed the title
martinkrulltott
changed the title
martinkrulltott
approved these changes
May 7, 2024
4 flaky tests on run #3180 ↗︎
Details:
|
|||||||||||||||||||||||||||||||||||||||
| Test | Artifacts | |
|---|---|---|
| systemSettings > uses Last 6 months as default relative period |
Screenshots
|
|
basemaps.cy.js • 1 flaky test • e2e-chrome-parallel-2.41
| Test | Artifacts | |
|---|---|---|
| Basemap checks > open map with unknown basemap uses fallback basemap (OSM Light) when system default basemap is invalid |
Screenshots
|
|
filemenu.cy.js • 1 flaky test • e2e-chrome-parallel-2.41
| Test | Artifacts | |
|---|---|---|
| File menu > saves a new map |
Screenshots
|
|
layers/eventlayer.cy.js • 1 flaky test • e2e-chrome-parallel-2.41
| Test | Artifacts | |
|---|---|---|
| Event Layers > shows error if no program selected |
Screenshots
|
|
Review all test suite changes for PR #3195 ↗︎
|
🎉 This PR is included in version 100.5.4 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implements DHIS2-15000
Requires dhis2/analytics#1664
Levels seem to get the translation, nameProperty not needed.
Settings: database language: Norwegian
displayName: shortName
For the OU tree, short names don't work. OULevels don't have short names.