Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: users losing work when opening as chart #3196

Merged
merged 3 commits into from
May 8, 2024
Merged

Conversation

BRaimbault
Copy link
Collaborator

@BRaimbault BRaimbault commented May 7, 2024

Implements DHIS2-15794


Updated openAs property (not used anywhere else) of LayerCard component to open link in new tab instead of current.
Updated text and icon on specific Menu Item to match new behavior.


Before:

Screenshare.-.2024-05-07.11_50_36.AM.mp4

After:

Screenshare.-.2024-05-07.11_49_13.AM.mp4

@dhis2-bot
Copy link
Contributor

dhis2-bot commented May 7, 2024

🚀 Deployed on https://pr-3196--dhis2-maps.netlify.app

@dhis2-bot dhis2-bot temporarily deployed to netlify May 7, 2024 09:56 Inactive
@dhis2-bot dhis2-bot temporarily deployed to netlify May 7, 2024 12:40 Inactive
@dhis2-bot dhis2-bot temporarily deployed to netlify May 8, 2024 07:17 Inactive
@BRaimbault BRaimbault merged commit 3c69a86 into dev May 8, 2024
18 checks passed
@BRaimbault BRaimbault deleted the fix/DHIS2-15794 branch May 8, 2024 09:19
dhis2-bot added a commit that referenced this pull request May 16, 2024
## [100.5.4](v100.5.3...v100.5.4) (2024-05-16)

### Bug Fixes

* system / user setting for display name not respected in Org Unit tree (DHIS2-15000) ([#3195](#3195)) ([8560478](8560478))
* users losing work when opening as chart ([#3196](#3196)) ([3c69a86](3c69a86))
@dhis2-bot
Copy link
Contributor

🎉 This PR is included in version 100.5.4 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Development

Successfully merging this pull request may close these issues.

None yet

3 participants