-
Notifications
You must be signed in to change notification settings - Fork 103
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[C4GT] Network-Score: Add tests for 'MessageIdAlreadyExists' #296
Comments
Hey @amarts , In this project we have to make a test which asserts that message already exists and we need to add this test in to network-score folder and that should pass three tests , namely Build , Cargo and test mentioned in the Readme.md File , Have I got the right idea ? let me know if I am wrong otherwise Tell me so i start to working on it |
@zeel991 Yes you have to add new test method in tests.rs which, |
Ok , I'll start working on this issue as the next thing .Thank you |
Hey @vatsa287 ,I have been trying to build cord in production mode using the command |
Thank you so much @vatsa287 , I wanted to share that while running the clippy command ( After commenting , I got this Error and tried very hard but couldn't fix it |
@zeel991 Interesting open the PR, lets check with GH tests. |
Description
Subtask under : cord-network/community#7
New testcase can be tested under
cargo test -p pallet-network-score
after adding it in the code.Goals
MessageIdAlreadyExists
for pallet/network-scoreExpected Outcome
MessageIdAlreadyExists
being returned properly in all the possible calls.Acceptance Criteria
NA
Implementation Details
Look at other test cases, and add a test case for the same.
Ex: In pallets/network-membership check method
test_duplicate_member_request
which validates error codeMembershipAlreadyAcquired
Mockups / Wireframes
NA
Product Name
CORD
Organization Name
Dhiway
Domain
Blockchain
Tech Skills Needed
Rust
Mentor(s)
@amarts
Complexity
[Low]
Category
[Test]
Sub Category
[Beginner friendly]
The text was updated successfully, but these errors were encountered: