[C4GT] Network-Score: Add tests for 'MessageIdAlreadyExists'

[vatsa287]

Description

Subtask under : cord-network/community#7

New testcase can be tested under cargo test -p pallet-network-score after adding it in the code.

Goals

• Add tests for MessageIdAlreadyExists for pallet/network-score

Expected Outcome

• Test should assert for MessageIdAlreadyExists being returned properly in all the possible calls.
• If there are more than one function returning this error code, all of them should be validated either as one test case or as multiple test cases.

Acceptance Criteria

NA

Implementation Details

Look at other test cases, and add a test case for the same.
Ex: In pallets/network-membership check method test_duplicate_member_request which validates error code MembershipAlreadyAcquired

Mockups / Wireframes

NA

---

Product Name

CORD

Organization Name

Dhiway

Domain

Blockchain

Tech Skills Needed

Rust

Mentor(s)

@amarts

Complexity

[Low]

Category

[Test]

Sub Category

[Beginner friendly]

[zeel991]

Hey @amarts , In this project we have to make a test which asserts that message already exists and we need to add this test in to network-score folder and that should pass three tests , namely Build , Cargo and test mentioned in the Readme.md File , Have I got the right idea ? let me know if I am wrong otherwise Tell me so i start to working on it
Thank you

[vatsa287]

@zeel991 Yes you have to add new test method in tests.rs which,
asserts the error code MessageIdAlreadyExists for all methods used in lib.rs.
Example: MessageIdAlreadyExists is being returned from methods revise_rating, register_rating etc.
Then call cargo test -p pallet-network-score. If it passes proceed with pre PR checks as mentioned in README.

[zeel991]

Ok , I'll start working on this issue as the next thing .Thank you

[zeel991]

Hey @vatsa287 ,I have been trying to build cord in production mode using the command cargo build --production , but it is not working and giving error , It shows that unexpected argument '--production' found , my cargo version is 1.75.0 , I tried the command cargo build --release , which worked fine , what should I do , can you help solve the error ?

[vatsa287]

@zeel991 Yes you can proceed to with cargo build --release.

@amarts Maybe I'll update README to reflect change from --production to --release.

[zeel991]

Thank you so much @vatsa287 , I wanted to share that while running the clippy command ( cargo clippy --all --no-deps --all-targets --features=runtime-benchmarks -- -D warnings) , I found a few errors , one was

I've currently just commented it out , but would appreciate your advice on this ,

After commenting , I got this Error and tried very hard but couldn't fix it

Can you Please Guide me as I have written the test but these issues wont let me get my PR merged .
Thank you

[vatsa287]

@zeel991 Interesting open the PR, lets check with GH tests.