Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Wip/945 knora freeze #951

Merged
merged 55 commits into from Aug 15, 2018
Merged

Wip/945 knora freeze #951

merged 55 commits into from Aug 15, 2018

Conversation

subotic
Copy link
Collaborator

@subotic subotic commented Jul 19, 2018 •
edited

Summary

  • create temp dirs at startup
  • update monitoring versions
  • timeout cleanup
  • add separate dispatchers

Issues

@subotic subotic added the bug something isn't working label Jul 19, 2018
@subotic subotic self-assigned this Jul 19, 2018
@codecov
Copy link

codecov bot commented Jul 19, 2018 •
edited

Codecov Report

Merging #951 into develop will decrease coverage by 0.1%.
The diff coverage is 87.36%.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop     #951      +/-   ##
===========================================
- Coverage    82.63%   82.52%   -0.11%     
===========================================
  Files          150      150              
  Lines        16997    17004       +7     
  Branches      1596     1627      +31     
===========================================
- Hits         14045    14033      -12     
- Misses        2952     2971      +19
Flag Coverage Δ
#integration 46.15% <71.57%> (-0.37%) ⬇️
#unit_e2e 81.4% <86.84%> (-0.11%) ⬇️
Impacted Files Coverage Δ
...a/org/knora/webapi/app/ApplicationStateActor.scala 72.22% <ø> (ø) ⬆️
webapi/src/main/scala/org/knora/webapi/Main.scala 0% <0%> (ø) ⬆️
...org/knora/webapi/routing/admin/StoreRouteADM.scala 87.5% <100%> (-0.74%) ⬇️
.../org/knora/webapi/routing/v2/StandoffRouteV2.scala 100% <100%> (ø) ⬆️
...ala/org/knora/webapi/routing/v2/ListsRouteV2.scala 100% <100%> (ø) ⬆️
...in/scala/org/knora/webapi/store/StoreManager.scala 85.71% <100%> (-1.79%) ⬇️
...org/knora/webapi/routing/admin/UsersRouteADM.scala 94.79% <100%> (+0.09%) ⬆️
...nora/webapi/routing/v1/AuthenticationRouteV1.scala 80.95% <100%> (ø) ⬆️
...rg/knora/webapi/routing/admin/GroupsRouteADM.scala 100% <100%> (ø) ⬆️
...ora/webapi/routing/admin/PermissionsRouteADM.scala 100% <100%> (ø) ⬆️
... and 31 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1c0e122...6f08ef6. Read the comment docs.

@benjamingeer benjamingeer mentioned this pull request Jul 26, 2018
Closed
@subotic
Merge branch 'wip/945-knora-freeze' of https://github.com/dhlab-basel…
0c4649c 
…/Knora into wip/945-knora-freeze
@subotic
feature (webapi): add separate dispatchers (ongoing)
6b082c1
@subotic
feature (tools): add thread sampling scripts
d2958ac
@subotic
feature (tools): make executable
82a8cbf
@subotic
feature (tools): change default values for jstackSeries
695856b
@subotic
feature (webapi): add instrumentation
e88f975
@subotic
feature (webapi): add separate dispatchers (ongoing)
2b5778e
@subotic
feature (webapi): add instrumentation
bf5ac13
@subotic
Merge branch 'wip/945-knora-freeze' of https://github.com/dhlab-basel…
fa4acbf 
…/Knora into wip/945-knora-freeze
@subotic
feature (webapi): add separate dispatchers (ongoing)
b3819ca
@subotic
build (webapi): ignore folder
173d252
@subotic
feature (tools): add thread sampling scripts
6bf6566
@subotic
feature (webapi): add separate dispatchers (ongoing)
877a6a8
@subotic
feature (webapi): add separate dispatchers (ongoing)
904103d
@subotic
Merge branch 'develop' into wip/945-knora-freeze
5d5ee79 
# Conflicts:
#	webapi/src/test/scala/org/knora/webapi/routing/AuthenticatorSpec.scala
@subotic
fix (webapi): merge conflict
225dee8
@subotic
Copy link
Collaborator Author

subotic commented Aug 14, 2018

I have run the import script again and it ran successfully.

@tobiasschweizer could you maybe do a review?

@subotic
doc (webapi): add release notes
acea56e
@subotic
fix (webapi): remove unused imports
09f6e0d
@subotic
fix (webapi): not freeing port on shutdown
10a2c2a
@subotic
feature (webapi): remove datadog reporter
097f595
@subotic
feature (webapi): remove datadog reporter
1cbc806
@subotic
Merge branch 'develop' into wip/945-knora-freeze
4645be9 
# Conflicts:
#	docs/src/paradox/00-release-notes/v1.7.0.md
#	docs/src/paradox/04-deployment/getting-started.md
#	webapi/src/main/scala/org/knora/webapi/KnoraService.scala
#	webapi/src/main/scala/org/knora/webapi/Settings.scala
#	webapi/src/main/scala/org/knora/webapi/SettingsConstants.scala
#	webapi/src/main/scala/org/knora/webapi/store/triplestore/TriplestoreManager.scala
#	webapi/src/main/scala/org/knora/webapi/store/triplestore/http/GraphProtocolAccessor.scala
#	webapi/src/main/scala/org/knora/webapi/store/triplestore/http/HttpTriplestoreConnector.scala
#	webapi/src/test/scala/org/knora/webapi/store/triplestore/AllTriplestoreSpec.scala
#	webapi/src/test/scala/org/knora/webapi/store/triplestore/TriplestoreManagerActorSpec.scala
@subotic
test (webapi): remove unused import
3e2bd84
@subotic subotic merged commit 2d5dc67 into develop Aug 15, 2018
@subotic subotic deleted the wip/945-knora-freeze branch August 15, 2018 15:30
@subotic
Copy link
Collaborator Author

subotic commented Aug 15, 2018

Thanks for the review :-)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tobiasschweizer tobiasschweizer tobiasschweizer approved these changes

Assignees

@subotic subotic

Labels
bug something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Knora freezes / stalls (without error) during import-tests
2 participants
@subotic @tobiasschweizer