Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

OperationMode.DISABLE constructor param has no effect #82

Closed
dleavitt opened this issue Dec 21, 2018 · 2 comments
Closed

OperationMode.DISABLE constructor param has no effect #82

dleavitt opened this issue Dec 21, 2018 · 2 comments
Assignees
@andreas-aeschlimann
Labels
bug Something isn't working

Comments

@dleavitt
Copy link

Since the value of OperationMode.DISABLE is 0, it fails the first clause in this check and the operationMode stays at 1:
https://github.com/dhlab-basel/json2typescript/blob/master/src/json2typescript/json-convert.ts#L134

Bug or unintentional feature? :)
@andreas-aeschlimann andreas-aeschlimann self-assigned this Dec 21, 2018
@andreas-aeschlimann andreas-aeschlimann added the bug Something isn't working label Dec 21, 2018
@andreas-aeschlimann
Copy link
Member

Lol funny "feature". Thanks for the report, will fix it of course.

Tests should also cover this case. I thought they did, apparently, they don't.

@andreas-aeschlimann
Copy link
Member

Fixed in new commit

andreas-aeschlimann added a commit that referenced this issue Jan 22, 2019
@andreas-aeschlimann
Fixed issue #82
fab82a6
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@andreas-aeschlimann andreas-aeschlimann

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@dleavitt @andreas-aeschlimann