Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Squish out any reference to things by corpus_name #18

Closed
ryaanahmed opened this issue Jun 20, 2019 · 1 comment
Closed

Squish out any reference to things by corpus_name #18

ryaanahmed opened this issue Jun 20, 2019 · 1 comment
Assignees

Comments

@ryaanahmed
Copy link
Member

This is mostly for @sophiazhi, who's going through and making our analysis functions take Corpus objects directly as arguments, rather than taking a corpus_name.

Just a heads up for @samimak37. I think we keep corpus_name around (but probably rename to name since why type my_corpus.corpus_name when you can type my_corpus.name?), but stop relying on it for anything other than as a convenience when printing results.

@ryaanahmed
Copy link
Member Author

done! thanks all. (there are a few instances of the string 'corpus_name' in the repo, but they're all in sensible places...)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants