New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

`prepare_metadata_for_build_wheel` and others incorrectly use name "settings" not "config_settings" #42

Closed

notatallshaw opened this issue May 10, 2024 · 0 comments · Fixed by #43

notatallshaw commented May 10, 2024

e.g.

enscons/enscons/api.py

Line 33 in 8a63d64

def prepare_metadata_for_build_wheel(metadata_directory, settings):

This is contray to the spec: https://peps.python.org/pep-0517/#prepare-metadata-for-build-wheel

And if a frontend calls via keyword arguments it fails: astral-sh/uv#3509

charliermarsh mentioned this issue

Rename settings to config_settings in PEP 517 hooks #43

Merged

dholth closed this as completed in #43

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment