Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Write Tag Support ? #15

Open
jcnoir opened this issue Aug 25, 2015 · 15 comments
Open

Write Tag Support ? #15

jcnoir opened this issue Aug 25, 2015 · 15 comments

Comments

@jcnoir
Copy link

jcnoir commented Aug 25, 2015

Is there any plan to write tags ?

@dhowden
Copy link
Owner

dhowden commented Aug 25, 2015

I don't have a use case for it at the moment, but am open to contributions providing that the implementation mirrors the code for reading tags.

@jcnoir
Copy link
Author

jcnoir commented Aug 25, 2015

Thank you for your answer.
I will try to do it but since I just begin coding with GO this may take some time...

@xhenner
Copy link
Contributor

xhenner commented Aug 26, 2015

I'm in the process of coding it, but have not a lot of time currently.

@jcnoir
Copy link
Author

jcnoir commented Aug 26, 2015

Good news. Do you have a branch in your repo where I can look at it ?

@dhowden
Copy link
Owner

dhowden commented Aug 28, 2015

@xhenner @jcnoir This sounds great! It would be best if you could develop this in a public branch (rather than putting everything in a pull request in one go) so that I can keep track of what's going on and maybe contribute too!

@xhenner
Copy link
Contributor

xhenner commented Sep 4, 2015

https://github.com/xhenner/tag/tree/writeid3v2 is the branch in which I work for write support when I have time

@cryptix
Copy link

cryptix commented Mar 19, 2016

I'd like to help with this. Anything low hanging I could tackle?

@GenieTim
Copy link

I know this issue is old in computer time, but is there any progress or alternative you switched to (For ID3 only: https://github.com/bogem/id3v2)? I would have some use cases, too...

@MasterOfTheTiger
Copy link

I am looking at this again. I have a use case for this, and have been reading the code to see how to implement it. I am particularly interested in OGG Vorbis Comment writing. Where would the code go. oggwrite.go?

@prologic
Copy link

My use-case for this is to add support to mt to generate thumbnails of videos and write them out to the Picture metdata tag of the MP4(s).

@bertvandepoel
Copy link

@xhenner I was wondering if you ever ended up finishing your branch?

@Sorrow446
Copy link

I wrote an MP4 tagger lib in Go if anyone needs since there wasn't one. https://github.com/Sorrow446/go-mp4tag
Would appreciate any contributors to help maintain and improve it, thanks.

@prologic
Copy link

I wrote an MP4 tagger lib in Go if anyone needs since there wasn't one. https://github.com/Sorrow446/go-mp4tag Would appreciate any contributors to help maintain and improve it, thanks.

Nice one! Can you add a cli tool for it too? e.g: ./cmd/mp4tag/main.go? 🤔 if you're open to it I can contribute that 👌

@bertvandepoel
Copy link

My Linux distro is getting closer and closer to loosing support, which means I will have to abandon Banshee player (it's 10 year old Mono, and doesn't build with modern versions). I would therefore like to create a new music manager/player, but tag writing is a big part of the feature set I would like to support. I'm therefore wondering if perhaps all the people here in this issue and in #71 could somehow get this to happen. Perhaps we can all write parts? Or we can perhaps combine donations to motivate someone to write it? I'm not sure how to get it done, but I would love to see it happen!

@Sorrow446
Copy link

I wrote an MP4 tagger lib in Go if anyone needs since there wasn't one. https://github.com/Sorrow446/go-mp4tag Would appreciate any contributors to help maintain and improve it, thanks.

Hello. I'm back after a bit. I've completely rewritten this, it doesn't rely on any other libraries/tools like AtomicParsley or abema's go-mp4 now. There's no corruption issues now either. Will have it up today or tomorrow.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

9 participants