Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Synchronise RiMarkov/RiLexicon with java #171

Open
6 tasks done
dhowe opened this issue Dec 5, 2021 · 3 comments
Open
6 tasks done

Synchronise RiMarkov/RiLexicon with java #171

dhowe opened this issue Dec 5, 2021 · 3 comments
Assignees
@Real-John-Cheung @KarlieZhao
Labels
priority: High

Comments

@dhowe
Copy link
Owner

dhowe commented Dec 5, 2021 •
edited by Real-John-Cheung
Loading

  • make sure options are clear (and clearly documented, see below)
  • attempt to create failing cases with new options set (ritajs)
  • sync java with new js code and tests in RiMarkov
  • sync java with new js code and tests in RiLexicon
  • check for other 'SYNC:' markers in js for upcoming release
  • Add 'text' option to RiTa.markov in docs if not there:
RiTa.markov(3, { text: stringOrArrayForModel });
This was referenced Dec 10, 2021
Merged
Merged
@dhowe dhowe changed the title Synchronise RiMarkov with java Synchronise RiMarkov/RiLexicon with java Feb 15, 2022
@Real-John-Cheung Real-John-Cheung mentioned this issue Mar 8, 2022
Merged
@dhowe
Copy link
Owner Author

dhowe commented Mar 13, 2022

@Real-John-Cheung status on this?

@Real-John-Cheung Real-John-Cheung mentioned this issue Mar 22, 2022
Merged
@Real-John-Cheung
Copy link
Collaborator

should be finished now

@dhowe
Copy link
Owner Author

dhowe commented Mar 23, 2022

great, let me know if there were any issues or questions..

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Real-John-Cheung Real-John-Cheung

@KarlieZhao KarlieZhao

Labels
priority: High
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@dhowe @Real-John-Cheung @KarlieZhao