Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release PyPI update on successful CI run/tag #32

Merged
merged 3 commits into from
Nov 28, 2017
Merged

Conversation

h-m-f-t
Copy link
Member

@h-m-f-t h-m-f-t commented Nov 27, 2017

Using instructions from docs.travis-ci.com and robinandeer.com, this change tells Travis to deploy a new version to PyPI after a successful run + a new tag on master.

(Note that the minor reformatting is courtesy of $ travis setup pypi.)

.travis.yml Outdated
- pip install flake8 pytest-cov pytest coveralls
- pip install -e .

- pip install flake8 pytest-cov pytest coveralls
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See above comment about list entries.

.travis.yml Outdated
- pytest --cov=trustymail
- flake8 .

- pytest --cov=trustymail
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See above comment about list entries.

.travis.yml Outdated
- '3.5'
- '3.6'

- '3.4'
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These list entries should be indented two spaces for readability. I'm not sure if YML requires or or not, but it's the standard thing to do.

.travis.yml Outdated
after_success:
- coveralls
- coveralls
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See above comment about list entries.

.travis.yml Outdated
after_success:
- coveralls
- coveralls
deploy:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not an expert on TravisCI, but this looks correct.

One question: Does TravisCI know to update the __version__ string in __init__ appropriately?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No, Travis will push out a tagged commit: https://docs.travis-ci.com/user/deployment/pypi/#Deploying-tags

@cisagov cisagov deleted a comment from coveralls Nov 27, 2017
@cisagov cisagov deleted a comment from coveralls Nov 27, 2017
@h-m-f-t
Copy link
Member Author

h-m-f-t commented Nov 27, 2017

(Coveralls has been tuned with comparable settings to pshtt)

Copy link
Collaborator

@IanLee1521 IanLee1521 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@jsf9k jsf9k merged commit 4af5a8e into master Nov 28, 2017
@jsf9k jsf9k deleted the automate-the-release branch November 28, 2017 14:10
@h-m-f-t h-m-f-t mentioned this pull request Dec 1, 2017
mcdonnnj added a commit that referenced this pull request Jan 23, 2023
Add python_requires argument for setup.py
mcdonnnj added a commit that referenced this pull request Jan 23, 2023
…n_and_checkout_action

Update Python and actions/checkout Versions
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants