Some DMARC fields not populated #57
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
values from the base domain if they're missing from the domain itself.
|
I can a full test of our Trustworthy Email Report generation and this does not appear to be breaking anything. It also provides what @dav3r needs for integrating crypto information into the reports, so I'm going to go ahead and merge it. |
mcdonnnj
pushed a commit
that referenced
this pull request
Jan 23, 2023
…gihub-dir Ensure that the cisagov devs are the owners of the .github directory
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I noticed that some of the
trustymailoutput fields are unpopulated when they really should be. For example, DMARC fields like percentage, ruas, rufs, etc. are only populated if the domain itself has a DMARC record. They are not populated if the DMARC configuration is inherited from the base domain.I also added some code to take into account
sp=when adjudicatingdmarc_policy.