Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bugfix/dns txt records can contain multiple char string objects #70

Merged

Conversation

jsf9k
Copy link
Member

@jsf9k jsf9k commented Mar 7, 2018

This pull request resolves #69.

uncomment it when debugging SMTP connection problems.
double-quoted strings it contains.  Also changed the code to use this
new function everywhere DNS TXT records are examined.

This commit is in response to NCATS Jira issue CYHY-629 and GitHub
issue #69.
@jsf9k jsf9k added the bug This issue or pull request addresses broken functionality label Mar 7, 2018
@jsf9k jsf9k self-assigned this Mar 7, 2018
Copy link
Member

@h-m-f-t h-m-f-t left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a note for posterity that the aim behind this fix is similar to that of #9.

Thanks @jsf9k @Essex09!

@jsf9k jsf9k merged commit 17bbaba into develop Mar 8, 2018
@jsf9k jsf9k deleted the bugfix/dns_txt_records_can_contain_multiple_char_string_objects branch March 8, 2018 16:06
mcdonnnj added a commit that referenced this pull request Jan 23, 2023
Improve gitignore file comments and organization.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug This issue or pull request addresses broken functionality
Projects
None yet
Development

Successfully merging this pull request may close these issues.

DMARC records containing multiple double-quoted strings not parsed correctly
2 participants