Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Reconcile various supported Python versions #89

Merged
merged 6 commits into from
Oct 6, 2018
Merged

Reconcile various supported Python versions #89

merged 6 commits into from
Oct 6, 2018

Conversation

IanLee1521
Copy link
Collaborator

  • Currently assuming the set of all that are available across setup.py, tox.ini, .travis.yml
  • Also adding Python 3.7

@IanLee1521
Reconcile various supported Python versions
b1cbaf1 
- Currently assuming the set of all that are available across setup.py, tox.ini, .travis.yml
- Also adding Python 3.7
@IanLee1521
Copy link
Collaborator Author

Hmm. Looks like Python 3.7 isn't supported by Travis? I'll work on that (I ran into this on my Mac which is what triggered my PR).

@h-m-f-t + @jsf9k -- Was there a decision to remove Python2 support? I see those tests fail. If Python2 is not supported, I'll update the PR to go the other way.

@jsf9k
Copy link
Member

jsf9k commented Sep 22, 2018

No decision was made to remove Python 3 support. We did have to do that for dhs-ncats/pshtt, since nabla-c0d3/sslyze no longer supports Python 2.

I wouldn't be against dropping Python 2 support. I don't use it, and it is on its way out. Supporting it is only going to become more difficult going forward.

Thoughts, @h-m-f-t?

@IanLee1521
Copy link
Collaborator Author

Nod. It looks like PyDNS might be pushing us towards dropping 2.x support (https://travis-ci.org/dhs-ncats/trustymail/jobs/431721269) since it seems to not install correctly...

@IanLee1521 IanLee1521 changed the title WIP: Reconcile various supported Python versions Reconcile various supported Python versions Oct 5, 2018
@IanLee1521
Copy link
Collaborator Author

Hi @jsf9k -- I'm removing the WIP: label as this should now be ready to be merged.

It is now a removal of the Python 2 support (and addition of Python 3.7 support), due to issues that are seen with PyDNS not supporting building / installing in Python 2.7.

@jsf9k
Copy link
Member

jsf9k commented Oct 6, 2018

I wanted to bump the version since we're dropping python 2.X support.

jsf9k
jsf9k approved these changes Oct 6, 2018
View reviewed changes
Copy link
Member

@jsf9k jsf9k left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great to me! Thank you for cleaning this up @IanLee1521!

@jsf9k jsf9k merged commit b583fd2 into cisagov:develop Oct 6, 2018
mcdonnnj added a commit that referenced this pull request Jan 23, 2023
@mcdonnnj
Merge pull request #89 from cisagov/improvement/specify_mdl_rules
bd030a1 
Add markdownlint Rules to Enforce Specific Formatting
mcdonnnj added a commit that referenced this pull request Jan 23, 2023
@mcdonnnj
Merge pull request #89 from cisagov/lineage/skeleton
e6ddc76 
Lineage pull request for: skeleton
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jsf9k jsf9k jsf9k approved these changes

@h-m-f-t h-m-f-t Awaiting requested review from h-m-f-t

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@IanLee1521 @jsf9k