Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "Some domains are listed as live even when DNS times out" #92

Conversation

jsf9k
Copy link
Member

@jsf9k jsf9k commented Oct 22, 2018

See comments by @h-m-f-t in #91

@jsf9k jsf9k self-assigned this Oct 22, 2018
@jsf9k jsf9k requested review from h-m-f-t and dav3r October 22, 2018 16:08
@jsf9k
Copy link
Member Author

jsf9k commented Oct 22, 2018

@h-m-f-t, the original impetus for #91 was that, if you run the trustymail command in the description of that pull request, the check for MX records raises a dns.exception.Timeout exception.

If you run it like this

$ trustymail --json --debug --timeout=30 --smtp-timeout=5 nara-at-work.gov

while connected to the NCATS VPN at least, you get a dns.resolver.NoNameservers exception. This leads to a different live result between the two cases because the two exceptions are handled differently.

I guess I need to dig in some more and figure out why the two different DNS hosts give different responses.

@jsf9k jsf9k merged commit e4f3ae6 into develop Oct 22, 2018
@jsf9k jsf9k deleted the revert-91-bugfix/domains_are_listed_as_live_even_when_dns_times_out branch October 22, 2018 19:54
mcdonnnj added a commit that referenced this pull request Jan 23, 2023
Use Outputs of cisagov/setup-env-github-action to Control Installed Program Versions
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants