Some library settings were not taking effect #93
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The timeout and lifetime settings only take effect when they are set on the resolver itself. I also took the opportunity to touch up some comments.
dav3r
approved these changes
Oct 22, 2018
mcdonnnj
added a commit
that referenced
this pull request
Jan 23, 2023
…re-commit_version Update the `ansible-lint` Version in the pre-commit Configuration
mcdonnnj
added a commit
that referenced
this pull request
Jan 23, 2023
…upport Officially support Python 3.10
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some settings for the
dnspythonPython library were not taking effect because they were being set incorrectly.I believe this should fix the issue reported by @climber-girl that I attempted to fix in #91, but it should not cause the issues mentioned by @h-m-f-t in that pull request either.