Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue Retrieving configFile in scraper.go #56

Closed
PumpkingWok opened this issue Sep 25, 2018 · 0 comments
Closed

Issue Retrieving configFile in scraper.go #56

PumpkingWok opened this issue Sep 25, 2018 · 0 comments

Comments

@PumpkingWok
Copy link
Contributor

PumpkingWok commented Sep 25, 2018

Hi there,

  • I found an issue when i try to retrieve configFile , initialized inside scraper.go

  • scraper.go, Row 55:

    • configFile := os.Getenv("GOPATH") + "/go/src/github.com/diadata-org/api-golang/exchange-scrapers/config/exchange-scrapers.json"
  • There are two issues:

  • I tested the code fixing these issues and it works.

[EDIT]

  • I exported GOPATH and it works now , also with os.Getenv("GOPATH"). It remains only the second issue.
  • For the first one maybe it could be useful to add a check to set default path in case of empty string returned, exactly how the stackoverflow example above.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants