Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

More overlap with Control.Lens #110

Closed
bergey opened this issue Sep 13, 2013 · 2 comments
Closed

More overlap with Control.Lens #110

bergey opened this issue Sep 13, 2013 · 2 comments
Labels

Comments

@bergey
Copy link
Member

bergey commented Sep 13, 2013

A few more overlaps, not mentioned in #82:

at
view
over

I don't know how important these are to either library. For Metafont work, I hid at from Lens and view, over from Diagrams. It's likely that if I knew what the other 3 functions did, I'd use them.

@byorgey
Copy link
Member

byorgey commented Sep 14, 2013

  • at: for creating Located things in diagrams, and accessing indexed containers (e.g. arrays, maps) in lens. Both can be important, it depends on your use case.
  • view: for setting a new Envelope in diagrams (probably not very common), and for turning a lens into a function (with (^.) as a synonym).
  • over: in diagrams, re-exported from colour, for compositing two colors with transparency. In lens, for editing the contents of a setter (with (%~) as a synonym).

Of these I'd be fine with removing our re-export of over; most users will not need it, and those who explicitly want to do some fancy color computations can import Data.Colour.

Two libraries as huge as diagrams and lens are almost guaranteed to have some name clashes. I'd rather not waste time rearranging the furniture; if we run into clashes that are particularly common or annoying we can consider them on a case-by-case basis.

@bergey
Copy link
Member Author

bergey commented Sep 16, 2013

if we run into clashes that are particularly common or annoying we can consider them on a case-by-case basis.

Makes sense. I ran into these working on the MetaFont module, and hiding whichever I wasn't using wasn't annoying.

@bergey bergey closed this as completed Mar 15, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants