Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Nice Names For Enums #1222

Closed
exelia-antonov opened this issue Sep 14, 2022 · 3 comments
Closed

Nice Names For Enums #1222

exelia-antonov opened this issue Sep 14, 2022 · 3 comments

Comments

@exelia-antonov
Copy link
Collaborator

Enums by default don't have text names to them. it'll be easier to use them in text timelines with text values, instead of having to rememember the numbers

image

image

@exelia-antonov
Copy link
Collaborator Author

might need to change them from being enums to implement. some languages you can set strings for enums for serialization/deserialization, Godot 3.x you could, but looks like enum was changed in GDScript 2.0 to be strictly ints

@Jowan-Spooner
Copy link
Collaborator

This is somewhat a duplicate of #1133, at least I was trying to describe the same problem as this one. This is a much better explenation though.
One other thought I had, was that I would love to optionally be able to name positions too. Like left, center, right instead of 1,3,5. Would lead to much more readable timelines as well. But positions and where they are is very project dependant, so it would need a different fix.

@exelia-antonov
Copy link
Collaborator Author

for the latter, that seems simple enough, we can just add an optional string value to class_name DialogicNode_PortraitPosition as well as the int position_index. then they could name it in the dialognode if they want to do that, and use it by either name or by number

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants