feat: split the main modules into multiple modules - DIA-61984 #106
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks! well done. |
hadrien
approved these changes
Nov 1, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Split the main
sqlaandasyncio_supportmodules into multiple smaller modules with their own purpose. This should help properly separate concerns instead of having everything bundled together. This change shouldn't cause any issue since we expect people to import the classes and objects from the root module likefrom fastapi_sqla import Session.Additional details
pagination.pyandasync_pagination.pyBasemodel is now part ofmodels.pyasyncio_support.pywas renamed toasync_sqla.pysince it's not containing all the async code anymore, and because it makes more sense with the addition ofasync_pagination.py. It shows in a better way that it's the async version of thesqlamodule.setupfunction was moved tobase.pyso that the__init__.pyfile only contains imports of what we want to expose from the root module. This uses a similar design as the pydantic or fastapi packages.Related JIRA issues
Validation
No code change, only moving things around. Tests still pass with minimal changes.