Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: update sqlalchemy links - DIA-53029 #83

Merged
merged 1 commit into from
Mar 16, 2023
Merged

docs: update sqlalchemy links - DIA-53029 #83

merged 1 commit into from
Mar 16, 2023

Conversation

hadrien
Copy link
Member

@hadrien hadrien commented Mar 16, 2023 •
edited
Loading

Description

  • Remove links to legacy sqlalchemy doc

Related

@codecov
Copy link

codecov bot commented Mar 16, 2023 •
edited
Loading

Codecov Report

Merging #83 (a93e4aa) into master (b78130e) will not change coverage.
The diff coverage is n/a.

❗ Current head a93e4aa differs from pull request most recent head 0e4d770. Consider uploading reports for the commit 0e4d770 to get more accurate results

@@            Coverage Diff            @@
##            master       #83   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files            6         6           
  Lines          403       403           
  Branches        52        52           
=========================================
  Hits           403       403
Flag Coverage Δ
python_version3.10-sqlalchemy1.3-asyncpg-aws_rds_iam 65.50% <ø> (ø)
python_version3.10-sqlalchemy1.3-asyncpg-noaws_rds_iam 63.52% <ø> (ø)
python_version3.10-sqlalchemy1.3-noasyncpg-aws_rds_iam 65.26% <ø> (ø)
python_version3.10-sqlalchemy1.3-noasyncpg-noaws_rds_iam 63.27% <ø> (ø)
python_version3.10-sqlalchemy1.4-asyncpg-aws_rds_iam 96.27% <ø> (ø)
python_version3.10-sqlalchemy1.4-asyncpg-noaws_rds_iam 94.29% <ø> (ø)
python_version3.10-sqlalchemy1.4-noasyncpg-aws_rds_iam 77.17% <ø> (ø)
python_version3.10-sqlalchemy1.4-noasyncpg-noaws_rds_iam 75.18% <ø> (ø)
python_version3.10-sqlalchemy2.0-asyncpg-aws_rds_iam 96.27% <ø> (ø)
python_version3.10-sqlalchemy2.0-asyncpg-noaws_rds_iam 94.29% <ø> (ø)
python_version3.10-sqlalchemy2.0-noasyncpg-aws_rds_iam 77.17% <ø> (ø)
python_version3.10-sqlalchemy2.0-noasyncpg-noaws_rds_iam 75.18% <ø> (ø)
python_version3.11-sqlalchemy1.3-asyncpg-aws_rds_iam 65.50% <ø> (ø)
python_version3.11-sqlalchemy1.3-asyncpg-noaws_rds_iam 63.52% <ø> (ø)
python_version3.11-sqlalchemy1.3-noasyncpg-aws_rds_iam 65.26% <ø> (ø)
python_version3.11-sqlalchemy1.3-noasyncpg-noaws_rds_iam 63.27% <ø> (ø)
python_version3.11-sqlalchemy1.4-asyncpg-aws_rds_iam 96.27% <ø> (ø)
python_version3.11-sqlalchemy1.4-asyncpg-noaws_rds_iam 94.29% <ø> (ø)
python_version3.11-sqlalchemy1.4-noasyncpg-aws_rds_iam 77.17% <ø> (ø)
python_version3.11-sqlalchemy1.4-noasyncpg-noaws_rds_iam 75.18% <ø> (ø)
python_version3.11-sqlalchemy2.0-asyncpg-aws_rds_iam 96.27% <ø> (ø)
python_version3.11-sqlalchemy2.0-asyncpg-noaws_rds_iam 94.29% <ø> (ø)
python_version3.11-sqlalchemy2.0-noasyncpg-aws_rds_iam 77.17% <ø> (ø)
python_version3.11-sqlalchemy2.0-noasyncpg-noaws_rds_iam 75.18% <ø> (ø)
python_version3.9-sqlalchemy1.3-asyncpg-aws_rds_iam 65.50% <ø> (ø)
python_version3.9-sqlalchemy1.3-asyncpg-noaws_rds_iam 63.52% <ø> (ø)
python_version3.9-sqlalchemy1.3-noasyncpg-aws_rds_iam 65.26% <ø> (ø)
python_version3.9-sqlalchemy1.3-noasyncpg-noaws_rds_iam 63.27% <ø> (ø)
python_version3.9-sqlalchemy1.4-asyncpg-aws_rds_iam 96.27% <ø> (ø)
python_version3.9-sqlalchemy1.4-asyncpg-noaws_rds_iam 94.29% <ø> (ø)
python_version3.9-sqlalchemy1.4-noasyncpg-aws_rds_iam 77.17% <ø> (ø)
python_version3.9-sqlalchemy1.4-noasyncpg-noaws_rds_iam 75.18% <ø> (ø)
python_version3.9-sqlalchemy2.0-asyncpg-aws_rds_iam 96.27% <ø> (ø)
python_version3.9-sqlalchemy2.0-asyncpg-noaws_rds_iam 94.29% <ø> (ø)
python_version3.9-sqlalchemy2.0-noasyncpg-aws_rds_iam 77.17% <ø> (ø)
python_version3.9-sqlalchemy2.0-noasyncpg-noaws_rds_iam 75.18% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

edouardlp
edouardlp reviewed Mar 16, 2023
View reviewed changes
.github/CODEOWNERS Outdated
@@ -0,0 +1 @@
* @dialoguemd/python-guild
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You'll need to do this

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unknown owner on line 1: make sure the team @dialoguemd/python-guild exists, is publicly visible, and has write access to the repository

Not sure if this will work

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see, team is not publicIIUC. Ok, will remove for now, was not the goal of PR.

@hadrien hadrien merged commit 253d840 into master Mar 16, 2023
@hadrien hadrien deleted the docs/DIA-53029/update branch March 16, 2023 15:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@edouardlp edouardlp edouardlp approved these changes

@arththebird arththebird arththebird approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@hadrien @edouardlp @arththebird