-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: fix search for tokens #218
Conversation
✔️ Deploy previews ready! |
✔️ Deploy previews ready! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks great! Thanks a bunch for the quick fix.
Okay so... type of searches:
Before: Now: Seems like there is no CSS: 1,3 I see it more naturally. Or, add But this is a design decision probably, I'm not sure why we decide to use There is also a noticed lag on switching to Token page, we should investigate it to improve. Technical improvement or Design Decision by splitting into sections. |
Yes, this is because the list is really long. The performance issue is in the render phase, so it's tricky to improve it, but we talked about if we can do some "lazy rendering" and add a loading state. I don't think pagination is possible since we have the table of contents with the anchor links. |
# [9.24.0](dialtone/v9.23.0...dialtone/v9.24.0) (2024-03-22) ### Bug Fixes * **Emoji:** dlt-1650 pad emoji unicode string with 0's ([#219](#219)) ([1eb4906](1eb4906)) * warn console error cleanup ([#221](#221)) ([65bb319](65bb319)) ### Documentation * add tokens keywords ([#220](#220)) ([20125f4](20125f4)) * fix search for tokens ([#218](#218)) ([ff46724](ff46724)) ### Features * added new headset icon and update listed icons ([#224](#224)) ([c1373ec](c1373ec)) * adding new blog for Types update ([#222](#222)) ([73b40f3](73b40f3))
docs: fix search for tokens
We discovered that for Android and iOS searching for tokens in figma format would not brung any results.
For example, searching for typography/body/md:
Before
Now
Obligatory GIF (super important!)
🛠️ Type Of Change
These types will increment the version number on release:
These types will not increment the version number, but will still deploy to documentation site on release:
📖 Jira Ticket
No Jira