Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Insufficient plural matching #4

Open
FlowMo7 opened this issue Jul 6, 2020 · 1 comment
Open

Insufficient plural matching #4

FlowMo7 opened this issue Jul 6, 2020 · 1 comment

Comments

@FlowMo7
Copy link
Member

FlowMo7 commented Jul 6, 2020

This is a cross-posted issue from diamirio/gradle-localize-plugin#1 (by @stefangeyer), which is also valid for this fastlane plugin.

Detailed description in the original issue, TL;DR:
When defining a plural without the one option, it is not interpreted as a plural.
Example (which wrongly will not be detected as a plural):

zero|No items available
other|Available items: %d

As mentioned in the original issue, the following line seems to be the problem:
https://github.com/tailoredmedia/fastlane-plugin-localize/blob/12d15603bcc42f87ff7e1fd74bb662591b9530f5/lib/fastlane/plugin/google_sheet_localize/actions/google_sheet_localize_action.rb#L414

That check would need to be expanded to match all possible keywords.

@mariohahn
Copy link
Collaborator

PR sind gerne gesehen (:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants