Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

adds a scoped object to store values under scope-wide names #55

Merged
merged 8 commits into from
Jul 5, 2018

Conversation

lukasheinrich
Copy link
Collaborator

the workflow view has new methods

  • addValue(key, value)
  • getValue(key)

note: keys are only write-once. They cannot be overwritten,
once they have a value assigned.

where the value being stored can be an expression that should
be executed against the Workflow Object. This will allow
stages use expressions stored under these 'well-known' names
inst. E.g.

instead of

parameters: {stages: foo, output: bar}

one could do
parameters: {expression_type: fromvalue, key: ascopewidekey}

assuming another stage has written e.g. the expression
'{stages: foo, output bar}' to 'ascopewidekey' the present
stage does not need to know anything about stage 'foo'

this will enable pattern such as taget-based workflows in which
dependencies are expressed via as scope-wide target names.

i.e. result data is accessible under unique "addresses"

  • stagename/nodeindex/result
  • nodeid/result
  • valuekey

the workflow view has new methods
- addValue(key, value)
- getValue(key)

note: keys are only write-once. They cannot be overwritten,
once they have a value assigned.

where the value being stored can be an expression that should
be executed against the Workflow Object. This will allow
stages use expressions stored  under these 'well-known' names
inst. E.g.

instead of

parameters: {stages: foo, output: bar}

one could do
parameters: {expression_type: fromvalue, key: ascopewidekey}

assuming another stage has written e.g. the expression
'{stages: foo, output bar}' to 'ascopewidekey' the present
stage does not need to know anything about stage 'foo'

this will enable pattern such as taget-based workflows in which
dependencies are expressed via as scope-wide target names
@coveralls
Copy link

coveralls commented Jun 24, 2018

Coverage Status

Coverage decreased (-0.4%) to 86.712% when pulling 630d0fb on values into 347ccad on master.

@lukasheinrich lukasheinrich merged commit 9240b44 into master Jul 5, 2018
@matthewfeickert matthewfeickert deleted the values branch February 3, 2022 21:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants