Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check for tests mkv files by filenames, not amount #1134

Closed
ptrcnull opened this issue Jun 25, 2024 · 0 comments · Fixed by #1152
Closed

Check for tests mkv files by filenames, not amount #1134

ptrcnull opened this issue Jun 25, 2024 · 0 comments · Fixed by #1152

Comments

@ptrcnull
Copy link
Collaborator

Currently we're checking how many files exist in the mkv directory, and redownloading the entire 180MB archive when the file count doesn't match:

if not os.path.exists(data_path) or len(os.listdir(data_path)) != 8:

This is a bit silly, since in build processes where you don't have access to internet you'd just extract the entire zip file, which contains a bit more than 8 files in total; instead, we should check if the files we want exist in the directory, somewhat like enzyme is doing currently:
https://github.com/Diaoul/enzyme/blob/e3086c3222cf732b63d35c31165ac20304dd2590/tests/test_mkv.py#L20

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant