We read every piece of feedback, and take your input very seriously.
To see all available qualifiers, see our documentation.
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Currently we're checking how many files exist in the mkv directory, and redownloading the entire 180MB archive when the file count doesn't match:
subliminal/tests/conftest.py
Line 443 in 929424c
This is a bit silly, since in build processes where you don't have access to internet you'd just extract the entire zip file, which contains a bit more than 8 files in total; instead, we should check if the files we want exist in the directory, somewhat like enzyme is doing currently: https://github.com/Diaoul/enzyme/blob/e3086c3222cf732b63d35c31165ac20304dd2590/tests/test_mkv.py#L20
The text was updated successfully, but these errors were encountered:
Successfully merging a pull request may close this issue.
Currently we're checking how many files exist in the mkv directory, and redownloading the entire 180MB archive when the file count doesn't match:
subliminal/tests/conftest.py
Line 443 in 929424c
This is a bit silly, since in build processes where you don't have access to internet you'd just extract the entire zip file, which contains a bit more than 8 files in total; instead, we should check if the files we want exist in the directory, somewhat like enzyme is doing currently:
https://github.com/Diaoul/enzyme/blob/e3086c3222cf732b63d35c31165ac20304dd2590/tests/test_mkv.py#L20
The text was updated successfully, but these errors were encountered: