exposes opts + bits #11
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
LGTM |
|
thank you @noffle . Could you add a test with this PR? |
|
Is it possible to supply less than 1024 or a non-scalar value of bits to this? I remember seeing this in go where they require the bits to at least be greater than 1024 as well as some tests that ensure it's a multiple of 1024. |
|
@diasdavid: Added a test. It's not very rigorous, but you aren't guaranteed a certain # of bytes in the resultant private key -- it varies from key to key. @nginnever: You can generate smaller keys (it would seem). go-ipfs puts that limit for security, but I think that should be an IPFS-level concern (application) rather than a library concern. |
|
LGTM, thank you @noffle and @nginnever for the input! :) |
|
released on 0.6.1 :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.