Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refresh opengraph - cache when post with url is posted #4966

Open
Faldrian opened this issue May 23, 2014 · 2 comments
Open

Refresh opengraph - cache when post with url is posted #4966

Faldrian opened this issue May 23, 2014 · 2 comments

Comments

@Faldrian
Copy link
Contributor

Faldrian commented May 23, 2014

Situation:

  • I submit a post with a opengraph-enabled website
  • diaspora requests opengraph-data and adds it to cache
  • When I submit a post later containing the same url, the cache is not updated from the website. Old information is shown that may be not on the website anymore and as user I'm confused where that description text is coming from.

Recently I ran into this issue when I linked to the TheRadio.CC Website. We changed a page on there and the cached version contains a preview to some hint we no longer have on the site.

The fix would be: Refresh the cache every time a post with that url is submitted, regardless of the cache state.

@goobertron
Copy link

It sounds as though each post should display a cached version from the time at which that post was made. The person who made the previous post with a link to that page intended to link to the page as it existed when they made the link, and updating the OG preview on their post could change the meaning of their post, or make it meaningless. So simply updating the cache on the server might not be the answer.

@Faldrian
Copy link
Contributor Author

I already thought this concern might come up. Yes, there should be one opengraph-cache-data-thing per post to be perfectly correct.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

6 participants