Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unify posts & markdown rendering on desktop and mobile #5466

Open
2 of 4 tasks
ghost opened this issue Dec 9, 2014 · 10 comments
Open
2 of 4 tasks

Unify posts & markdown rendering on desktop and mobile #5466

ghost opened this issue Dec 9, 2014 · 10 comments

Comments

@ghost
Copy link

ghost commented Dec 9, 2014

Mobile version and desktop version doesn't have the same rendering of posts and comments.
Till then the following differences have been detected :

capture d ecran 2015-01-02 a 18 02 49

@Flaburgan
Copy link
Member

We should simply use the same method to parse markdown in both mobile and desktop views.

@Raven24
Copy link
Member

Raven24 commented Dec 9, 2014

I don't know if that's feasible. Desktop is rendered by JS while mobile gets rendered on the server.
JS might be too intensive for mobile devices while rendering on the server has a negative impact on the speed of the desktop version.

I think we could instead have a formal test-suite of "our" markdown behaviour and let both renderers run against it to make sure they produce the same output.

@jhass
Copy link
Member

jhass commented Dec 9, 2014

Let's revisit this after #5457 is resolved.

@ghost
Copy link
Author

ghost commented Dec 9, 2014

JS might be too intensive for mobile devices while rendering on the server has a negative impact on the speed of the desktop version.

I really think we can greatly speed up by deactivating useless JS animation, e.g : the sliding to display the menu. Also, there are some thing that currently need connexion on mobile, e.g display the comment area when clincking on the button "comment". It fails when there's no connexion and eventually dispays the area several times.

Numerous things can be improved on mobile version.

@Flaburgan
Copy link
Member

e.g : the sliding to display the menu

The transition is done in pure CSS and is rendered by the GPU (at least with a gecko based rendered engine). There is almost no JS in the mobile view. I agree that a lot of things can be improved, and maybe speed is one, but it is not that bad.

@ghost
Copy link
Author

ghost commented Dec 10, 2014

Nope, not that bad, but just many many little ugly bugs everywhere. :/
Well, not everywhere but... Well you understood me !

@polsvoice
Copy link
Contributor

@Raven24 Maybe I could look at the JavaScript, run some tests, and see if there's any way to optimize it for mobile? Just a thought.

@Raven24
Copy link
Member

Raven24 commented May 9, 2015

I still think rendering on the server side for mobile is a good strategy, to be honest

@polsvoice
Copy link
Contributor

@Raven24 I'm curious why you think so.

@Fensterbank
Copy link
Contributor

Hi,

I found a problem with my post today, which seems pretty related to this issue:
https://pod.geraspora.de/posts/3840898

I have a literal </div> in my post content, which is visible in desktop view, but not existing in the mobile view.

I thought it could be a escaping problem, but the </div> has definiteley been removed by server side code. :-(

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants