Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Posts on the tag page can be reshared even if there were already reshared #4816

Closed
Flaburgan opened this issue Feb 25, 2014 · 3 comments · May be fixed by #7168
Closed

Posts on the tag page can be reshared even if there were already reshared #4816

Flaburgan opened this issue Feb 25, 2014 · 3 comments · May be fixed by #7168
Assignees
@svbergerem
Labels
🐞 bug 🎨 ui
Milestone
0.6.2.0

Comments

@Flaburgan
Copy link
Member

Flaburgan commented Feb 25, 2014 •
edited by jhass

The link "reshare" is still there but a pop up appears when we click on it saying that we already reshared that.
@jhass jhass added bug and removed backbone code labels Feb 25, 2014
@svbergerem
Copy link
Member

The same thing happens on the profile page.

@svbergerem
Copy link
Member

Now it also happens in the main stream. We display the reshare link if we are unable to find a reshare by the user in app/assets/javascripts/app/models/post/interactions.js. This works after we fetched the interactions but before the reshares have a different structure so we can't find the user's reshare with the linked function.

@goobertron
Copy link

Linked to #6594.

@svbergerem svbergerem self-assigned this Nov 2, 2016
This was referenced Nov 2, 2016
Open
Closed
@SuperTux88 SuperTux88 added this to the 0.6.2.0 milestone Nov 3, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@svbergerem svbergerem

Labels
🐞 bug 🎨 ui
Projects
None yet
Milestone
0.6.2.0
Development

Successfully merging a pull request may close this issue.

Load initial comments in the SPV on pageload svbergerem/diaspora
5 participants
@jhass @SuperTux88 @Flaburgan @goobertron @svbergerem