Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Trying to add a too large image file in the desktop view does nothing. #8212

Open
denschub opened this issue Feb 26, 2021 · 1 comment
Open
Labels

Comments

@denschub
Copy link
Member

Something's broken. No resize happens, but also no spinner, no error message, nothing. I can see the browser allocating some blobs, but nothing happens at all, so that's fun. We should probably push #8071 to get rid of the current brokenness.

@denschub
Copy link
Member Author

denschub commented Feb 26, 2021

Looking at a browser profile, it actually appears it's doing something - loading the image into a canvas, and then requesting a data url multiple times. I have no idea why we do that - it ain't smart, we should indeed post the blob to the server, not trying to allocate some gigantomanic data uri containing the image. I couldn't find the callee's function name (_generateScaledImage) in our code, so this is probably an upstream dep.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant