Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make 'autofollow_on_join_user' configuration a list #4986

Open
jaywink opened this issue Jun 4, 2014 · 14 comments · May be fixed by #8430
Open

Make 'autofollow_on_join_user' configuration a list #4986

jaywink opened this issue Jun 4, 2014 · 14 comments · May be fixed by #8430

Comments

@jaywink
Copy link
Contributor

jaywink commented Jun 4, 2014

autofollow_on_join_user -setting should be a list to enable auto follow of several accounts for new signups.

Example - I have a pod and an official podmin account for it. I want my new users to follow this account automatically to receive pod news. But I would also like them to follow the diaspora HQ account to receive project news.

Config:
https://github.com/diaspora/diaspora/blob/develop/config/diaspora.yml.example#L226

@goobertron
Copy link

I completely support this proposal. It would be really useful.

@Flaburgan
Copy link
Member

Not sure that this is needed, that's why community spotlights exist imo.

@jaywink
Copy link
Contributor Author

jaywink commented Jun 11, 2014

AFAIK community spotlight is not something that newly registered users automatically follow?

@Flaburgan
Copy link
Member

Hm, don't think so, it's just recommendation.

@goobertron
Copy link

As far as I know, community spotlight is also only available if the podmin has enabled it and manually added accounts to the list. So it can't act as a replacement for auto-follow.

@Flaburgan
Copy link
Member

community spotlight is also only available if the podmin has enabled it and manually added accounts to the list

Exactly like for auto-follow :p
My point is, I think we should not abuse of auto-follow. Adding a contact to a user without asking him anything is not something "normal". A solution could be to improve it to have something like "Do you want to keep in touch with the diaspora* project?" and propose to add the contact.
Especially, diaspora HQ is in english, most of my users doesn't read nor care about it.

@goobertron
Copy link

Adding a contact to a user without asking him anything is not something "normal". A solution could be to improve it to have something like "Do you want to keep in touch with the diaspora* project?" and propose to add the contact.

There's already an issue for that, #4324 :P

This is for something different, a feature enabling a podmin to suggest more than one account to auto-follow. The explanation/option in #4324 is important for reasons of transparency, but this is a separate feature suggestion and shouldn't depend on 4324 being implemented first, because auto-following two accounts (DHQ and podmin) without explanation isn't really any worse than auto-following DHQ alone without any explanation...

@aka001
Copy link
Contributor

aka001 commented Mar 1, 2015

I would like to start working on this issue. Is this issue meant to open ?(I am unable to infer from the comments)

@jaywink
Copy link
Contributor Author

jaywink commented Mar 1, 2015

@aka001 getting this done would be awesome!

Basically

  • the config autofollow_on_join_user should instead of being just a string be a list.
  • when a new user signs up, they should be set to autofollow each of the accounts on this list.

If you need help, don't forget to ask!

@jaywink
Copy link
Contributor Author

jaywink commented Mar 1, 2015

Oh, I guess not to break backwards compat it would be nice to make sure to either make sure when reading the config the code falls back to understanding it as a string OR we can introduce a new config variable autofollow_on_join_users and mark autofollow_on_join_user as deprecated and drop it in the next major after this goes in.

@aka001
Copy link
Contributor

aka001 commented Mar 1, 2015

@jaywink Thank you for the detailed reply. I would like to confirm one more thing. The autofollow_on_join_user variable needs to be modified in config/defaults.yml, right ?

@jaywink
Copy link
Contributor Author

jaywink commented Mar 2, 2015

@aka001 yes there but of course also the diaspora.yml.example too.

@phaidros7
Copy link

I want to back this issue, and am interested if there is any progress, yet ?

thanks!

@denschub
Copy link
Member

Feel free to post a bounty... There's a link below the initial issue text.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

8 participants