Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[hellfire] OperateL2Door - Please check bin exactness #2053

Closed
Chance4us opened this issue May 27, 2020 · 10 comments
Closed

[hellfire] OperateL2Door - Please check bin exactness #2053

Chance4us opened this issue May 27, 2020 · 10 comments

Comments

@Chance4us
Copy link
Contributor

When the code was decompiled, the comparison was not the same.
Please check the assembler code.

OperateL2Door

@AJenbo
Copy link
Member

AJenbo commented May 27, 2020

It's known that it's not bin exact for hellfire: #1397

@AJenbo AJenbo closed this as completed May 27, 2020
@Chance4us
Copy link
Contributor Author

That's why I decompiled it. It looks a little different in the picture above.
Look at the yellow dots. It should be checked whether the changes will lead to bin exactness.

@AJenbo
Copy link
Member

AJenbo commented May 27, 2020

If you like we can help you setup the tools so that you can check and make a pull request that makes it bin exact

@Chance4us
Copy link
Contributor Author

Yes. Thank you. That would be helpful. I'll be asking some questions about the tools soon if that's okay.

@AJenbo
Copy link
Member

AJenbo commented May 27, 2020

Definitely. Though it would be easiest via chat, there is even a channel there with a guide for how to get things running for working on Hellfire.

@mewmew
Copy link
Contributor

mewmew commented May 27, 2020

Happy to see you join us in the reversing efforts @Chance4us :)

@Chance4us
Copy link
Contributor Author

Thank you also for the effort of all of you guys.
Can anyone describe how I can join the chat channel?

@qndel
Copy link
Member

qndel commented May 28, 2020

https://discord.gg/MX8VhHu

@Chance4us
Copy link
Contributor Author

Thank you @qndel

@qndel
Copy link
Member

qndel commented Oct 11, 2020

void OperateL2Door(int pnum, int i, DIABOOL sendflag)
{
	int dpx, dpy;

	dpx = abs(object[i]._ox - plr[pnum]._px);
	dpy = abs(object[i]._oy - plr[pnum]._py);
	if (dpx == 1 && dpy <= 1 && object[i]._otype == OBJ_L2LDOOR)
		OperateL2LDoor(pnum, i, sendflag);
	if (dpx <= 1 && dpy == 1 && object[i]._otype == OBJ_L2RDOOR)
		OperateL2RDoor(pnum, i, sendflag);
}

bin exact in this form

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants